Comments (7)
I'll look into this a bit further and see if there is a way I can add this functionality without rewriting the action completely. I'm thinking that I might be able to call a separate tool or script to do the client-side encryption first before calling the mirror
function of MinIO client.
from s3-backup.
Thanks! Hope you find it useful.
I think it might already be possible. This action is just a wrapper around the mirror
command of MinOI Client. Looking at the flags available for the mirror
command it looks possible to send the necessary secret key/value pair for encryption.
--encrypt value encrypt/decrypt objects (using server-side encryption with server managed keys)
--encrypt-key value encrypt/decrypt objects (using server-side encryption with customer provided keys)
ref: https://docs.min.io/docs/minio-client-complete-guide.html#mirror
When I have some time I'll try and test it out and update the README with an example. If you get it working, please let me know!
from s3-backup.
@peter-evans Interesting!
Unfortunately it seems to be only server-side encryption. AWS can still access/decrypt the data, which is what I wanted to avoid if possible.
I don't know how closely this action is tied to minIO, but if we'd be using the any of the AWS SDKs (Go, Python, Ruby, etc) we could use their built-in client-side encryption.
from s3-backup.
I think that would be useful to a lot of people, since source code is often sensitive and not having to trust the backup location can be quite convenient.
from s3-backup.
Looked into this a bit more and it seems non-trivial to implement. Even the AWS SDKs do not all support client-side encryption fully. I'm a bit nervous about attempting to write my own implementation and I was hoping to find some existing client or tool to use. I didn't find any stand-alone tool for the encryption part because it seems that the client-side encryption needs to be closely tied to the uploading logic.
The tool that I did find that looks interesting is duplicati. This seems to support client-side encryption and a wide range of options to store the backup, including S3. Would that be of interest to you if I created an action backed by the duplicati client?
from s3-backup.
I decided to just create the action since someone is bound to find it useful. I'll test it soon and try and get a working example of client-side encryption to S3 working.
https://github.com/peter-evans/duplicati-action
from s3-backup.
@peter-evans Looks interesting! Will take a look in a while
from s3-backup.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s3-backup.