rwb static error about rwb HOT 12 CLOSED

I have this, too. Tried installing json-loader but that didn't help.

from rwb.

@meyer is on the case

from rwb.

@meyer is the best

from rwb.

Yey @meyer !

from rwb.

so much pressure 😓

from rwb.

Oops did not mean to close.

@meyer I made my own fork and applied your commit and now I get this:

$: rwb static

/Users/***/.nvm/versions/node/v4.2.2/lib/node_modules/rwb/node_modules/style-loader/addStyles.js:30
        if (typeof options.singleton === "undefined") options.singleton = isOldIE();
^
ReferenceError: window is not defined
    at /Users/***/.nvm/versions/node/v4.2.2/lib/node_modules/rwb/node_modules/style-loader/addStyles.js:14:1
    at /Users/***/.nvm/versions/node/v4.2.2/lib/node_modules/rwb/node_modules/style-loader/addStyles.js:9:1
    at e.exports (/Users/***/.nvm/versions/node/v4.2.2/lib/node_modules/rwb/node_modules/style-loader/addStyles.js:30:1)
    at Object.<anonymous> (webpack:///MyComponent.css?12a2:7:1)
    at t (webpack/bootstrap f9215b977c34d7bcad1b:9:1)
    at Object.<anonymous> (bundle.js:13877:24)
    at Object.<anonymous> (bundle.js:14157:28)
    at t (webpack/bootstrap f9215b977c34d7bcad1b:9:1)
    at Object.<anonymous> (bundle.js:14694:21)
    at Object.<anonymous> (bundle.js:14703:28)

from rwb.

@resistdesign yeeep, I was a little overzealous in copying the serve loaders over. Sorry about that.

from rwb.

@meyer np, it's all part of the process! :)

from rwb.

@meyer Just tried your fork at master and it worked a bit better but I'm referring to window in my app code so now I get:

const CURRENT_PROTOCOL = window.location.protocol;
                         ^
ReferenceError: window is not defined

Is that just a global that needs to be set in webpack? New issue time?

from rwb.

@resistdesign window is not set on purpose. Since rwb is an implementation of "isomorphic" JS, you may not have access to the browser APIs at load time.

Think about it: during the static build step, what should window.location.protocol return? Since it's not being run in an actual web page served from a web server, there's no location.protocol. Instead, you can refer to window in React lifecycle hooks that only run in the browser (i.e. componentDidMount()).

from rwb.

ah ok!

from rwb.

I did not know isomorphic was a goal for this :)

from rwb.