Traces not visible in Zipkin UI, when open tracing is used about petabridge.tracing.zipkin HOT 7 CLOSED

We use the OpenTracing API for this heavily in https://phobos.petabridge.com - it works. Might be a configuration issue - are you still having this issue?

from petabridge.tracing.zipkin.

Having the same issue. Seems the using(){} with finish on dispose is not functioning as expected. Running the same code but using span.Start() and span.Finish() works.

from petabridge.tracing.zipkin.

Dispose on the Span object itself calls Finish

Maybe the issue is what's happening inside the Scope object - I don't believe we have a reproduction for that, so we can take a look.

from petabridge.tracing.zipkin.

Yes. My bad. Using statement has nothing to do with it. Indeed when using scopes via StartActive() it will no longer send traces. Another strange thing is that when I switch sample code to

var sb = _tracer.BuildSpan("no-op").WithTag("empty", true);
var span = sb.Start();
await Task.Delay(1000);
span.Finish();

on a simple GET method it will keep sending spans indefinitely cycling the same threads while it is not executing/reaching that code block multiple times. Though that seems to be a different issue (if not just my misunderstanding of what happens) and should not pollute this thread.

from petabridge.tracing.zipkin.

@Aaronontheweb @bastijnv
The issue here is that ISpanBuilder.StartActive is using IScopeManager internally so keep track of active span (some details [here[(https://github.com/opentracing/opentracing-csharp#scopes-and-within-process-propagation)). You have to set ScopeManager property of ZipkinTracerOptions to have StartActive working.

Currently there is no built-in implementation of IScopeManager in Petabridge.Tracing.Zipkin, except NoopScopeManager class which always returnes NoopSpanBuilder, so basically ISpanBuilder.StartActive resolves to NoopSpan.Instance, which does nothing. That's why nothing is sent to Zipkin.

As a quick solution you might consider using AsyncLocalScopeManager implementation of IScopeManager that is built in OpenTracing package, like this:

 var tracer = new ZipkinTracer(new ZipkinTracerOptions(url, "ZipkinTest", debug: true)
{
    ScopeManager = new AsyncLocalScopeManager()
});

@Aaronontheweb This is not clear from README, but what do you think about using AsyncLocalScopeManager as a default scope manager instead of NoopScopeManager? This may help people have this StartActive method working out of the box.
If you agree, I will submit small PR for that, with reproducing spec

from petabridge.tracing.zipkin.

from petabridge.tracing.zipkin.

So the reason why I never ran into this bug - Phobos sets up a scope manager by default in its configuration. This is definitely an issue on our end.

from petabridge.tracing.zipkin.