Git Product home page Git Product logo

Comments (4)

Aaronontheweb avatar Aaronontheweb commented on July 3, 2024

@IgorFedchenko I believe we already support this, but I'm not 100% sure - might be as simple as firing up a test cluster and seeing if the pbm cluster leave command supports multiple -a parameters.

from petabridge.cmd-issues.

IgorFedchenko avatar IgorFedchenko commented on July 3, 2024

@Aaronontheweb Nope, this is not supported right now:

cluster leave -a localhost:8081 -a localhost:8082
ERR: could not execute command
Saw more than 1 value for argument [address] for command [cluster leave], which is not allowed for [address].

And this is explicitly disabled with AllowMultiple(false) in the source code, so I will need to check if allowing multiple parameters will break anything.

from petabridge.cmd-issues.

IgorFedchenko avatar IgorFedchenko commented on July 3, 2024

Actually, internal command handling seems to be supporting that - it is assuming that multiple switches could be given. I will need to test if this works with AllowMultiple(true) setting.

UPDATE: nope, it is doing SingleOrDefault to make sure it is handling only one Leave at a time. I will need to learn more about possible reasons then.

from petabridge.cmd-issues.

IgorFedchenko avatar IgorFedchenko commented on July 3, 2024

Ok, so as discussed in chat, there is no strong reason to not allow multiple addresses to be specified here. I will make a PR soon.

from petabridge.cmd-issues.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.