[ENHANCEMENT] change type of `refreshRate` and `pid` flag to unsigned int about grofer HOT 6 CLOSED

Picking this one up also.

from grofer.

picking up this!

from grofer.

#68

from grofer.

@prncvrm LOL, don't rush to add an incomplete PR to an issue, which someone has already started working and commented so also.

from grofer.

Hi guys,
As a general good practice, its always recommended that you ask if an issue is available to be worked on and if so, whether you can work on it, rather than declaring that you will be working on this. As far as I can tell, both of you commented in the same manner at more or less the same exact time, there's no real way to decide this.

In order to try and be as fair as possible to you guys, we will be closing the PR by @souvikmaji for this issue since he has already contributed to this repo (this is done because there's a conflict in terms of whose PR should be accepted). But @souvikmaji's PR is valid too and that's why we'll be adding the hacktoberfest-accepted label to it so that it counts towards hacktoberfest even though it is closed.

And one last thing, please follow the PR template. It is extremely important that you do so. The only reason that we'll be considering @prncvrm's PR is that it is borderline acceptable in terms of the issue it is solving, but bear in mind to follow the templates and contribution guidelines.

from grofer.

@MadhavJivrajani thanks. @souvikmaji i really didn't see your comment back then. its less than a 1 min diff btwn our comments 👍

from grofer.