Git Product home page Git Product logo

Comments (4)

Gpinchon avatar Gpinchon commented on July 2, 2024 1

I did a fork, do you want me to do a PR ?

from glew-cmake.

Perlmint avatar Perlmint commented on July 2, 2024

First of all, Thanks for piling an issue.
I'm sorry, But I can't find a point using CMAKE_SOURCE_DIR - only used in here - possibly occurring error on the master branch. Can you specify the actual point?

from glew-cmake.

Gpinchon avatar Gpinchon commented on July 2, 2024

Sorry, I meant CMAKE_CURRENT_BINARY_DIR instead of CMAKE_BINARY_DIR.
But after investigating, I think it's even better to avoid setting CMAKE_ARCHIVE_OUTPUT_DIRECTORY, CMAKE_LIBRARY_OUTPUT_DIRECTORY and CMAKE_RUNTIME_OUTPUT_DIRECTORY altogether, as it keeps parent projects from choosing where to put glew's files.
And by default, dll and lib files are put in build/bin and build/lib anyway.

[EDIT] After testing I can confirm that by removing the CMake output setting from CMakeLists.txt, the files are correctly placed by default (ie : the dll next to my .exe, and the lib in /lib)

from glew-cmake.

Perlmint avatar Perlmint commented on July 2, 2024

If you can make a PR, I will appreciate it.

from glew-cmake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.