Possible improvement to `core#capture` about cli HOT 6 CLOSED

Released 1.0.0-beta.25 🎉

from cli.

Whoops sorry just blindly created it in the same repo as the previous issue, thanks for moving!

That resolution sounds perfect. Thank you so much for the continued incredible support!

from cli.

Hello again @nathanshelly!

I've moved this issue to the new repo since it relates directly to it.

If you can provide authorization headers via the headers option, that may also work to bypass the login screen entirely.

percy.capture({
  name: 'Behind Login',
  url: 'http://localhost:3000/protected',
  headers: {
    Authorization: 'XXXXXX'
  }
})

However, this issue did bring to my attention that if any page navigation occurs inside of the execute function, then it will also result in the error you encountered. Rather than introduce another execute option, I've opted to move the injection step to after execute is called. I also noticed there was another nuance where if the page was redirected, the incorrect URL was being provided to the snapshot method.

I've addressed both of those issues in PR #99. If you can confirm that this would solve your issue, I'll go ahead and merge it.

from cli.

Following up here I was hopeful I would be able to install the latest, unreleased changes including this fix via something like this in my package.json:

"@percy/cli": "git+https://github.com/percy/cli.git#b6bceeeff58f35f379dcd2141db55259344bb3d1",

Unfortunately this fails with an error message about a missing version field. This seems to be due to a limitation of yarn with monorepo structures like this repo where it's attempting to install the top-level package.json which has no version field instead of the nested packages/cli folder that I'd need. Any chance you'd be willing to cut a new beta release so I could use the fix?

from cli.

Sorry about the delay in releasing! I meant to do that asap, but wasn't near a computer when I merged the PR from mobile. Then my brain turned off work mode all weekend and I forgot.

I'll have a release cut shortly! 👍

from cli.

No worries whatsoever, thanks!

from cli.