Git Product home page Git Product logo

Comments (12)

Robdel12 avatar Robdel12 commented on May 23, 2024 2

Thanks for that! Looks like it is an infrastructure issue -- all the assets are correctly captured by the SDK. I spoke to some folks that work on the infrastructure and we've uncovered an issue over the past few days and have rolled out a (hopeful fix) over the past hour.

I'll close this issue since it's not an SDK bug, BUT not closing the discussion or triaging here. Very curious to hear how this continues to play out (and the infra folks are aware of this gh issue)

from cli.

warreneblackwell avatar warreneblackwell commented on May 23, 2024 1

@Robdel12 It is still happening frequently. See latest builds: 11199388, 11196297, 11195134

from cli.

Robdel12 avatar Robdel12 commented on May 23, 2024 1

Hm, this is interesting -- it looks like some of these are actually missing assets being captured by the SDK. Would you be able to add --verbose to the CI run and pass logs over for a build that has missing assets? Those logs will have responses for those assets / hints as to why they're not being captured.

from cli.

Robdel12 avatar Robdel12 commented on May 23, 2024 1

Thanks for that! The assets that are missing in the snapshot aren't in the logs for asset discovery either. So that means the network idle timeout might be too quick for the these assets to be requested/discovered in asset discovery. I'd try setting the network-idle-timeout to 250ms to see if these assets will be discovered: https://docs.percy.io/docs/cli-configuration#discovery

version: 2
snapshot:
  # your current config here
discovery:
  network-idle-timeout: 250 # ms (up to 500ish is good)

This tells Percy's asset discovery to wait for 250ms for zero requests to be made by the captured DOM snapshot before closing asset discovery (and moving onto the next snapshot). 150 seems a bit too quick and there's assets that aren't being discovered reliably

from cli.

Robdel12 avatar Robdel12 commented on May 23, 2024

Hey @khitrenovich! Could you link to a build or two (or snapshot IDs) where this is happening? This usually isn't an SDK issue, but it would be good to rule that out for sure (and having a build will help :D)

from cli.

khitrenovich avatar khitrenovich commented on May 23, 2024

@Robdel12 You can check 11163677 and 11167161, for example. Pretty much every build of this project has a visual diff - either fonts are being changed / image glyphs disappeared, or things are back to normal.

from cli.

khitrenovich avatar khitrenovich commented on May 23, 2024

@Robdel12 Thank you, we'll keep an eye and let you know how the things are going!

from cli.

khitrenovich avatar khitrenovich commented on May 23, 2024

@Robdel12 It still happens (see build 11170338), although it's hard to tell the frequency yet.

from cli.

warreneblackwell avatar warreneblackwell commented on May 23, 2024

@Robdel12 - Please see attached logs for build 11249225.

percyLog.txt

from cli.

vdineva avatar vdineva commented on May 23, 2024

I am seeing the same assets loading issues on a different project. I have tried setting the network-idle-timeout to 500ms and it's currently set to 5000ms - but it did not help in my case. The only difference between the 2 projects is that the project I'm working on is on the free trial version. The only thing stopping us from moving to a paid version is this unstable behavior we're experiencing with Percy

from cli.

warreneblackwell avatar warreneblackwell commented on May 23, 2024

@Robdel12 - setting network-idle-timeout: 250 does not appear to have helped. Some additional info: resources that do not show up are referred from the CSS (whereas others are direct and always show up).

from cli.

warreneblackwell avatar warreneblackwell commented on May 23, 2024

@Robdel12 - Any further suggestion or insight? We really would like to resolve this ASAP, or the product is not very useful for us.

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.