Comments (12)
Thanks for that! Looks like it is an infrastructure issue -- all the assets are correctly captured by the SDK. I spoke to some folks that work on the infrastructure and we've uncovered an issue over the past few days and have rolled out a (hopeful fix) over the past hour.
I'll close this issue since it's not an SDK bug, BUT not closing the discussion or triaging here. Very curious to hear how this continues to play out (and the infra folks are aware of this gh issue)
from cli.
@Robdel12 It is still happening frequently. See latest builds: 11199388, 11196297, 11195134
from cli.
Hm, this is interesting -- it looks like some of these are actually missing assets being captured by the SDK. Would you be able to add --verbose
to the CI run and pass logs over for a build that has missing assets? Those logs will have responses for those assets / hints as to why they're not being captured.
from cli.
Thanks for that! The assets that are missing in the snapshot aren't in the logs for asset discovery either. So that means the network idle timeout might be too quick for the these assets to be requested/discovered in asset discovery. I'd try setting the network-idle-timeout
to 250ms to see if these assets will be discovered: https://docs.percy.io/docs/cli-configuration#discovery
version: 2
snapshot:
# your current config here
discovery:
network-idle-timeout: 250 # ms (up to 500ish is good)
This tells Percy's asset discovery to wait for 250ms for zero requests to be made by the captured DOM snapshot before closing asset discovery (and moving onto the next snapshot). 150 seems a bit too quick and there's assets that aren't being discovered reliably
from cli.
Hey @khitrenovich! Could you link to a build or two (or snapshot IDs) where this is happening? This usually isn't an SDK issue, but it would be good to rule that out for sure (and having a build will help :D)
from cli.
@Robdel12 You can check 11163677 and 11167161, for example. Pretty much every build of this project has a visual diff - either fonts are being changed / image glyphs disappeared, or things are back to normal.
from cli.
@Robdel12 Thank you, we'll keep an eye and let you know how the things are going!
from cli.
@Robdel12 It still happens (see build 11170338), although it's hard to tell the frequency yet.
from cli.
@Robdel12 - Please see attached logs for build 11249225.
from cli.
I am seeing the same assets loading issues on a different project. I have tried setting the network-idle-timeout
to 500ms and it's currently set to 5000ms - but it did not help in my case. The only difference between the 2 projects is that the project I'm working on is on the free trial version. The only thing stopping us from moving to a paid version is this unstable behavior we're experiencing with Percy
from cli.
@Robdel12 - setting network-idle-timeout: 250 does not appear to have helped. Some additional info: resources that do not show up are referred from the CSS (whereas others are direct and always show up).
from cli.
@Robdel12 - Any further suggestion or insight? We really would like to resolve this ASAP, or the product is not very useful for us.
from cli.
Related Issues (20)
- `percy upload -v .` fails uploading base images.
- Depends on vulnerable versions of yaml HOT 1
- Canvas is not shown on Safari with version 1.15.0 or later HOT 6
- Percy is not recognizing currency formatting from 1.19.2 onwards HOT 4
- Get JSON data back from percy build:wait HOT 5
- Incorrect export of core types HOT 2
- Percy cli throws error when finalizing a build HOT 1
- Unable to use @percy/storybook with `--parallel` flag HOT 1
- Outdated docs for static snapshot options HOT 2
- percy snapshot should offer a dump option for debugging HOT 2
- Fonts arent showing up in percy snapshots HOT 2
- Renaming snapshots without or with visual changes (target snapshot name)
- percy/cli v1.27 incompatible with percy-cypress HOT 8
- Allow per-snapshot configuration of discovery.networkIdleTimeout HOT 2
- storybook field is no longer working in the config file HOT 1
- v.1.26.3 breaks storybook config HOT 1
- Reference
- Reference HOT 1
- Error: Navigation failed: Timed out waiting for the page load event - breaks our tests HOT 9
- 500 Internal Server Error - GET https://registry.npmjs.org/@percy%2fcli-config - KV GET failed: 401 Unauthorized HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.