Comments (5)
Sweet, thanks for that! I can see that the root resource is for some reason being discovered/captured in asset discovery, which is a big no. We'll keep digging to see why that's happening -- it shouldn't ever make its away into the discovery queue ๐คจ
Also worth noting that we're doing jest.retryTimes(3); in our test suite to automatically retry failing tests in cases of errors. That might play a role here too.
That's not the issue now, but that will cause issues if there is a retried test. Percy snapshots can't be retried (for now, we're working on making snapshot creation lazy for these cases). Any retried test with a snapshot in it, will throw errors.
from cli.
Hey @swissspidy! Would you be able to share logs or build details? The only thing that's required to be unique is the name.
from cli.
Here's a recent CI log:
https://github.com/google/web-stories-wp/runs/2896753308#step:13:18
The first error there is originating from this place where we call percySnapshot()
:
Also worth noting that we're doing jest.retryTimes(3);
in our test suite to automatically retry failing tests in cases of errors. That might play a role here too.
from cli.
Alright, @swissspidy this should be fixed in v1.0.0-beta.55 ๐ https://www.npmjs.com/package/@percy/cli/v/1.0.0-beta.55 Thanks for raising the issue!
from cli.
Awesome, thank you so much for this quick turnaround! It works like a charm now.
from cli.
Related Issues (20)
- 500 Internal Server Error - GET https://registry.npmjs.org/@percy%2fcli-config - KV GET failed: 401 Unauthorized HOT 2
- Please allow longer network idle timeouts HOT 2
- Cannot read properties of undefined (reading 'id') HOT 1
- Set browser prefers-color-scheme to test apps in dark mode HOT 1
- H
- [percy:core] Error : Timed out waiting for network requests to idle HOT 1
- Percy is not running, disabling snapshot HOT 4
- Browserstack: Build not created, Error: connect ECONNREFUSED HOT 3
- Bumping to different versions [Dependabot] HOT 1
- Reference Error: Excessive alias count indicates a resource exhaustion attack in percy url yaml with 360 url items HOT 2
- [percy] ParseError: Unexpected argument 'storybook'
- Percy exec fails binding to ipv6 HOT 2
- 413 Payload Too Large
- static.ignore option doesn't work
- Using PERCY_ENABLE can lead to NPE HOT 4
- V1.28.2 introduces a bug causing our CI to fail due to bad requests HOT 3
- Base64 encoded SVGs cause error when capturing HOT 4
- Add `percy exec` flag to avoid failure for Percy-related issues HOT 2
- Add a command that takes screenshots and writes them to a file instead of uploading HOT 1
- Percy does not work with Yarn PnP HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.