Comments (8)
@itsjwala this fixed the cssRules error but i still cant use the latest version it gives some unknown errors now not showing up in the log https://github.com/infor-design/enterprise-wc/actions/runs/4365577412/jobs/7637547882#step:10:29623
Just mentioning it in case you have an idea. If not i can try to get verbose logs turned on (is that possible I forget) when i have more time and make a new issue.
from cli.
@tmcconechy I see the visual changes are happening due to javascript being enabled. Is there any reason for enabling it? (If its Shadow DOM, then we support it since 1.19.2+) We noticed that the visual errors are a result of javascript side effects. Can you try disabling it and running the builds?
from cli.
@samarsault i disabled it on infor-design/enterprise-wc#1165 but it a) still has a lot of errors b) the images dont look correct anymore.
We do use shadowRoot (web components). But not sure i recall why we enabled it. I think support suggested it. Still this only is a problem moving up from 1.18.0
https://github.com/infor-design/enterprise-wc/actions/runs/4375912710
from cli.
@tmcconechy we see some unusual diffs in your build and will take a look. Can you try using the latest version setting enableJavascript:true
and disableShadowDOM:true
?
from cli.
@samarsault still doing some weird things https://github.com/infor-design/enterprise-wc/actions/runs/4397781859/jobs/7716169624 infor-design/enterprise-wc#1165
I would think we want JS and shadowRoot since these are JS components and they use web components/shadowRoot
from cli.
@samarsault should i be using the support at browser stack instead? My concern is we can no longer update and use percy so might need to look at other options before renewing.
from cli.
@tmcconechy For the enableJavascript: false case, I see the following classes of visual changes in your build
- Date & Time changes in tables : These are expected because javascript is no longer running in the rendering environment
- Width changes: This can happen If you handle responsive changes in your javascript. See this doc for reference.
Also, is the cypress test failure happening because of percy? If yes, what is the error message?
If you still face any issue, please reach out through support. It would help us in prioritizng this.
Edit:
For the enableJavascript: true
case, we've identified an issue with shadow dom + enableJavascript: true configuration. Fixing this in #1210
from cli.
ok thanks @samarsault cant seem to get it to work with any configuration i can come up with. We use JS and and its all web components so Js off is not an option (will show nothing). Shadow root is also needed, without it will show nothing on the page. This is the last build infor-design/enterprise-wc#1165 every time it just comes up with errors on each test i cant figure out. So will log a support ticket for now. Cheers
from cli.
Related Issues (20)
- 500 Internal Server Error - GET https://registry.npmjs.org/@percy%2fcli-config - KV GET failed: 401 Unauthorized HOT 2
- Please allow longer network idle timeouts HOT 2
- Cannot read properties of undefined (reading 'id') HOT 1
- Set browser prefers-color-scheme to test apps in dark mode HOT 1
- H
- [percy:core] Error : Timed out waiting for network requests to idle HOT 1
- Percy is not running, disabling snapshot HOT 4
- Browserstack: Build not created, Error: connect ECONNREFUSED HOT 3
- Bumping to different versions [Dependabot] HOT 1
- Reference Error: Excessive alias count indicates a resource exhaustion attack in percy url yaml with 360 url items HOT 2
- [percy] ParseError: Unexpected argument 'storybook'
- Percy exec fails binding to ipv6 HOT 2
- 413 Payload Too Large
- static.ignore option doesn't work
- Using PERCY_ENABLE can lead to NPE HOT 4
- V1.28.2 introduces a bug causing our CI to fail due to bad requests HOT 3
- Base64 encoded SVGs cause error when capturing HOT 5
- Add `percy exec` flag to avoid failure for Percy-related issues HOT 2
- Add a command that takes screenshots and writes them to a file instead of uploading HOT 1
- Percy does not work with Yarn PnP HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.