Git Product home page Git Product logo

Comments (8)

tmcconechy avatar tmcconechy commented on June 27, 2024

@itsjwala this fixed the cssRules error but i still cant use the latest version it gives some unknown errors now not showing up in the log https://github.com/infor-design/enterprise-wc/actions/runs/4365577412/jobs/7637547882#step:10:29623

Just mentioning it in case you have an idea. If not i can try to get verbose logs turned on (is that possible I forget) when i have more time and make a new issue.

from cli.

samarsault avatar samarsault commented on June 27, 2024

@tmcconechy I see the visual changes are happening due to javascript being enabled. Is there any reason for enabling it? (If its Shadow DOM, then we support it since 1.19.2+) We noticed that the visual errors are a result of javascript side effects. Can you try disabling it and running the builds?

from cli.

tmcconechy avatar tmcconechy commented on June 27, 2024

@samarsault i disabled it on infor-design/enterprise-wc#1165 but it a) still has a lot of errors b) the images dont look correct anymore.

We do use shadowRoot (web components). But not sure i recall why we enabled it. I think support suggested it. Still this only is a problem moving up from 1.18.0

https://github.com/infor-design/enterprise-wc/actions/runs/4375912710

from cli.

samarsault avatar samarsault commented on June 27, 2024

@tmcconechy we see some unusual diffs in your build and will take a look. Can you try using the latest version setting enableJavascript:true and disableShadowDOM:true?

from cli.

tmcconechy avatar tmcconechy commented on June 27, 2024

@samarsault still doing some weird things https://github.com/infor-design/enterprise-wc/actions/runs/4397781859/jobs/7716169624 infor-design/enterprise-wc#1165

I would think we want JS and shadowRoot since these are JS components and they use web components/shadowRoot

from cli.

tmcconechy avatar tmcconechy commented on June 27, 2024

@samarsault should i be using the support at browser stack instead? My concern is we can no longer update and use percy so might need to look at other options before renewing.

from cli.

samarsault avatar samarsault commented on June 27, 2024

@tmcconechy For the enableJavascript: false case, I see the following classes of visual changes in your build

  • Date & Time changes in tables : These are expected because javascript is no longer running in the rendering environment
  • Width changes: This can happen If you handle responsive changes in your javascript. See this doc for reference.

Also, is the cypress test failure happening because of percy? If yes, what is the error message?
If you still face any issue, please reach out through support. It would help us in prioritizng this.

Edit:
For the enableJavascript: true case, we've identified an issue with shadow dom + enableJavascript: true configuration. Fixing this in #1210

from cli.

tmcconechy avatar tmcconechy commented on June 27, 2024

ok thanks @samarsault cant seem to get it to work with any configuration i can come up with. We use JS and and its all web components so Js off is not an option (will show nothing). Shadow root is also needed, without it will show nothing on the page. This is the last build infor-design/enterprise-wc#1165 every time it just comes up with errors on each test i cant figure out. So will log a support ticket for now. Cheers

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.