Git Product home page Git Product logo

Comments (5)

branislav-remen avatar branislav-remen commented on June 27, 2024 1

@branislav-remen can you share a reproducible html page with shadow dom?

for example:
https://www.axa.ch/en/myaxa/company-registration.html#/

Heading (on top of the page) and Button (on bottom) use shadow dom.
Details about components used on this page can be found here: https://github.com/axa-ch-webhub-cloud/pattern-library

from cli.

samarsault avatar samarsault commented on June 27, 2024

@branislav-remen can you share a reproducible html page with shadow dom?

from cli.

itsjwala avatar itsjwala commented on June 27, 2024

@branislav-remen can you give v1.19.1-alpha.0 a try?

from cli.

branislav-remen avatar branislav-remen commented on June 27, 2024

@itsjwala it works with v1.19.1-alpha.0 👍 Thank you. 👏

But I see some warnings not related to the topic of this issue:

  1. [percy] Heads up! The current version of @percy/cli is more than 10 releases behind! 1.19.1-alpha.0 -> 1.19.0-alpha.0 - This message is confusing 😄
  2. Stylesheet related warnings, but screenshots in Percy looks correctly (1:1 with real website).
Running 24 tests using 1 worker

     1 [chromium] › src/tests/visualRegression.spec.ts:28:1 › Registrations page
[percy] Snapshot taken: Registrations page-card
[percy] Encountered snapshot serialization warnings:
[percy] - stylesheet with attributes - [ data-name: axa-table-myaxa ] - was not serialized
  ✓  1 [chromium] › src/tests/visualRegression.spec.ts:28:1 › Registrations page (9s)
     2 [chromium] › src/tests/visualRegression.spec.ts:46:1 › Add Main Registration page
[percy] Encountered snapshot serialization warnings:
[percy] - stylesheet with attributes - [ data-name: axa-fieldset-myaxa ] - was not serialized
[percy] - stylesheet with attributes - [ data-name: axa-radio-myaxa ] - was not serialized
  ✓  2 [chromium] › src/tests/visualRegression.spec.ts:46:1 › Add Main Registration page (5s)
...

how can I rid of this second warning?

from cli.

itsjwala avatar itsjwala commented on June 27, 2024

Hey @branislav-remen glad this is fixed for you.

  1. we store Github releases in a file located at node_modules/@percy/cli/.releases (for Unix), I had forgotten to draft a release yesterday, just remove this cache file, and it will not show this warning message.
rm node_modules/@percy/cli/.releases
  1. As part of v1.19.1-alpha.0 release we'd added this serialization warning message, currently there is no way via a flag to disable this warning message.

I'm closing this issue as the original 🐛 is fixed, please feel free to open another issue/discussion thread if you face any problems, and thanks for reporting the bug 😄 !

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.