Git Product home page Git Product logo

Comments (3)

itsjwala avatar itsjwala commented on June 22, 2024

Hey @yjaaidi 👋

have you checked this?

import { createRequire } from 'module';

export const PERCY_DOM = createRequire(import.meta.url).resolve('@percy/dom');

we do something similar here

export const PERCY_DOM = createRequire(import.meta.url).resolve('@percy/dom');

This way you'll only require @percy/dom package to be present and you can pass the file content to eval here
https://github.com/marmicode/marmicode/blob/spike/split-percy-snapshot-and-upload/libs/testing/src/cypress-commands.ts#L40

from cli.

yjaaidi avatar yjaaidi commented on June 22, 2024

Hi @itsjwala, thank you for the quick response.
Actually, this doesn't really solve the problem. My calls to Percy utils were superfluous and I just forgot to remove them.
The current call to serializeDOM() works but it just doesn't capture the resources. The domSnapshot.resources array is empty while it should capture some styles and pictures.
https://github.com/marmicode/marmicode/blob/e6a72e5228cdffcff87612a8a79e4c375c24c368/libs/testing/src/cypress-commands.ts#L35

from cli.

itsjwala avatar itsjwala commented on June 22, 2024

Okay there seems to be some misunderstanding here, serializeDOM only serializes certain elements for assets we have something called asset discovery phase.

you can learn more here https://docs.percy.io/docs/debugging-sdks#how-percy-works

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.