Comments (3)
Hey @yjaaidi 👋
have you checked this?
import { createRequire } from 'module';
export const PERCY_DOM = createRequire(import.meta.url).resolve('@percy/dom');
we do something similar here
Line 9 in 5f86910
This way you'll only require @percy/dom
package to be present and you can pass the file content to eval here
https://github.com/marmicode/marmicode/blob/spike/split-percy-snapshot-and-upload/libs/testing/src/cypress-commands.ts#L40
from cli.
Hi @itsjwala, thank you for the quick response.
Actually, this doesn't really solve the problem. My calls to Percy utils were superfluous and I just forgot to remove them.
The current call to serializeDOM()
works but it just doesn't capture the resources. The domSnapshot.resources
array is empty while it should capture some styles and pictures.
https://github.com/marmicode/marmicode/blob/e6a72e5228cdffcff87612a8a79e4c375c24c368/libs/testing/src/cypress-commands.ts#L35
from cli.
Okay there seems to be some misunderstanding here, serializeDOM
only serializes certain elements for assets we have something called asset discovery
phase.
you can learn more here https://docs.percy.io/docs/debugging-sdks#how-percy-works
from cli.
Related Issues (20)
- Allow per-snapshot configuration of discovery.networkIdleTimeout HOT 2
- storybook field is no longer working in the config file HOT 1
- v.1.26.3 breaks storybook config HOT 1
- Error: Navigation failed: Timed out waiting for the page load event - breaks our tests HOT 9
- 500 Internal Server Error - GET https://registry.npmjs.org/@percy%2fcli-config - KV GET failed: 401 Unauthorized HOT 2
- Please allow longer network idle timeouts HOT 2
- Cannot read properties of undefined (reading 'id') HOT 1
- Set browser prefers-color-scheme to test apps in dark mode HOT 1
- H
- [percy:core] Error : Timed out waiting for network requests to idle HOT 1
- Percy is not running, disabling snapshot HOT 4
- Browserstack: Build not created, Error: connect ECONNREFUSED HOT 3
- Bumping to different versions [Dependabot] HOT 1
- Reference Error: Excessive alias count indicates a resource exhaustion attack in percy url yaml with 360 url items HOT 2
- [percy] ParseError: Unexpected argument 'storybook'
- Percy exec fails binding to ipv6 HOT 2
- 413 Payload Too Large
- static.ignore option doesn't work
- Using PERCY_ENABLE can lead to NPE HOT 4
- V1.28.2 introduces a bug causing our CI to fail due to bad requests HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.