Git Product home page Git Product logo

Comments (3)

feerrenrut avatar feerrenrut commented on August 29, 2024 2

I started looking at PRs here for an example of pep8speaks in use. It seems it might serve multiple purposes to "eat your own dogfood" in this case. Using pep8speaks on this project will provide a demonstrate the features, and also help to clean up the violations in the project.

I hope this is taken as constructive.

from pep8speaks.

CAM-Gerlach avatar CAM-Gerlach commented on August 29, 2024

Also, at the same time, I can fix a couple related standards-compliance issues, namely:

  • A few files are missing terminating EOLs, as is required by a number of standards (and triggering Git warnings, breaking a number of *nix utilities, etc), namely:

    pep8speaks/__init__.py
    requirements/test.txt
    templates/index.html
    tests/__init__.py
    
  • A number of files are missing the # -*- coding: utf-8 -*- line required by PEP 263; however, if its not compatible with Python 2 or at least realistically expected to be run on such, then it isn't strictly necessary. The files:

    ./conftest.py
    ./pep8speaks/constants.py
    ./pep8speaks/models.py
    ./pep8speaks/utils.py
    ./pep8speaks/__init__.py
    ./tests/pep8speaks/test_handlers.py
    ./tests/pep8speaks/test_helpers.py
    ./tests/pep8speaks/test_models.py
    ./tests/pep8speaks/test_utils.py
    ./tests/test_app.py
    ./tests/__init__.py
    

from pep8speaks.

OrkoHunter avatar OrkoHunter commented on August 29, 2024

Hi @CAM-Gerlach ! Thank you for your suggestions on the PEP 8 issues and note about EOLs. I agree that the code itself had those issues.

As of today, there are no style issues detected by pycodestyle in the project. As a note, I would like to add that there are some configurations of pycodestyle that this project uses. I should probably add it to cfg files for other tools to read them. Related : #95

from pep8speaks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.