Git Product home page Git Product logo

Comments (6)

pengx17 avatar pengx17 commented on June 29, 2024 2

I am releasing a new version based on our discussion here.

from logseq-dev-theme.

Bad3r avatar Bad3r commented on June 29, 2024 1

@pengx17 That's a great solution! I like the look of the dotted line more.

I am not sure about using this color for the dotted line. Maybe consider using the same color used for page links but for the dotted line or a different shade of blue (example: #a3cef1)

from logseq-dev-theme.

Bad3r avatar Bad3r commented on June 29, 2024 1

Awesome! Thank you! 🚀

from logseq-dev-theme.

pengx17 avatar pengx17 commented on June 29, 2024

@Bad3r
Screen Shot 2021-12-26 at 5 14 14 PM
it looks fine to me on Mac 🤔. I think the block ref background may not need to be that outstanding though, but I am not an expert on coloring & theming. Do you have a suggestion about how to make it blend in a better way?

from logseq-dev-theme.

Bad3r avatar Bad3r commented on June 29, 2024

I think it's very outstanding. I find it somewhat distracting when it's in the middle of a text block, specially when compared to a page link, e.g. [[logseq]]

Also, there seems to be an extra space at the end of a block ref. 

A possible solution is to remove the background color completely and change the text color similar to how page links are handled, or use the default logseq style and modify the underline color to #313942 (left sidebar color) or #92b8d7 (page link color).
 

I am also not sure about the # symbol in the start. I think the logseq default theme handles this better with just adding an underline with a different color.

from logseq-dev-theme.

pengx17 avatar pengx17 commented on June 29, 2024

@Bad3r oh, I get what you mean. The block reference style was made like this was because this theme was originally forked from https://github.com/PiotrSss/logseq-clean-themes, including the # sign and background. I have not thought about the issue back then, but now I believe you are right: having the two may disrupt the reading experience.

IMO the way you suggested that using different colors may not apply well to distinguish between block/page references. Alternatively, I propose to use dotted underlines for block references, and leave what it is for block ref, like this:

image

What do you think?

from logseq-dev-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.