Git Product home page Git Product logo

Comments (5)

gwaldron avatar gwaldron commented on August 16, 2024

Thanks Remo! All are fixed.

from rocky.

remoe avatar remoe commented on August 16, 2024

I've tried it with the following CMake config:

-DROCKY_SUPPORTS_MBTILES=OFF
-DROCKY_SUPPORTS_GDAL=OFF

Compile errors:

1

In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:7:
In file included from /src/rocky/src/rocky/Map.h:15:
/src/rocky/src/rocky/LayerCollection.h:88:35: error: member access into incomplete type 'rocky::Map'
        std::shared_lock lock(_map->_mapDataMutex);
                                  ^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:6:
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.h:8:
/src/rocky/src/rocky/TerrainTileModel.h:20:11: note: forward declaration of 'rocky::Map'
    class Map;
          ^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:7:
In file included from /src/rocky/src/rocky/Map.h:15:
/src/rocky/src/rocky/LayerCollection.h:98:35: error: member access into incomplete type 'rocky::Map'
        std::shared_lock lock(_map->_mapDataMutex);
                                  ^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:6:
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.h:8:
/src/rocky/src/rocky/TerrainTileModel.h:20:11: note: forward declaration of 'rocky::Map'
    class Map;
          ^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:7:
In file included from /src/rocky/src/rocky/Map.h:15:
/src/rocky/src/rocky/LayerCollection.h:108:35: error: member access into incomplete type 'rocky::Map'
        std::shared_lock lock(_map->_mapDataMutex);
                                  ^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:6:
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.h:8:
/src/rocky/src/rocky/TerrainTileModel.h:20:11: note: forward declaration of 'rocky::Map'
    class Map;
          ^
3 errors generated.

The code has compile issues in LayerCollection.h. The forward declare of Map:

https://github.com/pelicanmapping/rocky/blob/main/src/rocky/LayerCollection.h#L13

can't work with the following template implementation:

https://github.com/pelicanmapping/rocky/blob/main/src/rocky/LayerCollection.h#L88

And it doesn't compile with #include <rocky/Map.h> .

2

rocky/src/rocky/TMS.cpp:758:25: error: no matching function for call to object of type 'const rocky::ReadImageStreamService' (aka 'const function<Result<shared_ptr<rocky::Image>> (basic_istream<char> &, basic_string<char, char_traits<char>, allocator<char>>, const rocky::IOOptions &)>')
        auto image_rr = io.services().readImageFromStream(
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from rocky/src/rocky/TMS.cpp:6:
In file included from rocky/src/rocky/TMS.h:8:
In file included from rocky/src/rocky/URI.h:8:
In file included from rocky/src/rocky/Common.h:34:

/usr/include/c++/v1/__functional/function.h:1059:9: note: candidate function not viable: expects an lvalue for 1st argument
    _Rp operator()(_ArgTypes...) const;
        ^
1 error generated.

3

rocky/src/rocky/URI.cpp:21:22: error: use of undeclared identifier 'OPENSSL_VERSION_STR'
ROCKY_ABOUT(openssl, OPENSSL_VERSION_STR)

from rocky.

remoe avatar remoe commented on August 16, 2024

The job and job_scheduler class must be separated, because of circular dependencies? Or should at least the job::dispatch implementation be moved to Threading.cpp?

from rocky.

gwaldron avatar gwaldron commented on August 16, 2024

Remo, I feel like many of these issues are just templates being instantiated before they are used. Is there some king of clang option for this? Because it isn't a problem on MSVC. Don't know about GCC.

I made another push to (hopefully) address these latest ones.

from rocky.

remoe avatar remoe commented on August 16, 2024

I haven't found a clang option to configure template instancing. Currently, I'm able to compile the project with my additional PR. But it need more work to link and run it.

from rocky.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.