Comments (5)
Thanks Remo! All are fixed.
from rocky.
I've tried it with the following CMake config:
-DROCKY_SUPPORTS_MBTILES=OFF
-DROCKY_SUPPORTS_GDAL=OFF
Compile errors:
1
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:7:
In file included from /src/rocky/src/rocky/Map.h:15:
/src/rocky/src/rocky/LayerCollection.h:88:35: error: member access into incomplete type 'rocky::Map'
std::shared_lock lock(_map->_mapDataMutex);
^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:6:
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.h:8:
/src/rocky/src/rocky/TerrainTileModel.h:20:11: note: forward declaration of 'rocky::Map'
class Map;
^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:7:
In file included from /src/rocky/src/rocky/Map.h:15:
/src/rocky/src/rocky/LayerCollection.h:98:35: error: member access into incomplete type 'rocky::Map'
std::shared_lock lock(_map->_mapDataMutex);
^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:6:
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.h:8:
/src/rocky/src/rocky/TerrainTileModel.h:20:11: note: forward declaration of 'rocky::Map'
class Map;
^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:7:
In file included from /src/rocky/src/rocky/Map.h:15:
/src/rocky/src/rocky/LayerCollection.h:108:35: error: member access into incomplete type 'rocky::Map'
std::shared_lock lock(_map->_mapDataMutex);
^
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.cpp:6:
In file included from /src/rocky/src/rocky/TerrainTileModelFactory.h:8:
/src/rocky/src/rocky/TerrainTileModel.h:20:11: note: forward declaration of 'rocky::Map'
class Map;
^
3 errors generated.
The code has compile issues in LayerCollection.h. The forward declare of Map:
https://github.com/pelicanmapping/rocky/blob/main/src/rocky/LayerCollection.h#L13
can't work with the following template implementation:
https://github.com/pelicanmapping/rocky/blob/main/src/rocky/LayerCollection.h#L88
And it doesn't compile with #include <rocky/Map.h>
.
2
rocky/src/rocky/TMS.cpp:758:25: error: no matching function for call to object of type 'const rocky::ReadImageStreamService' (aka 'const function<Result<shared_ptr<rocky::Image>> (basic_istream<char> &, basic_string<char, char_traits<char>, allocator<char>>, const rocky::IOOptions &)>')
auto image_rr = io.services().readImageFromStream(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from rocky/src/rocky/TMS.cpp:6:
In file included from rocky/src/rocky/TMS.h:8:
In file included from rocky/src/rocky/URI.h:8:
In file included from rocky/src/rocky/Common.h:34:
/usr/include/c++/v1/__functional/function.h:1059:9: note: candidate function not viable: expects an lvalue for 1st argument
_Rp operator()(_ArgTypes...) const;
^
1 error generated.
3
rocky/src/rocky/URI.cpp:21:22: error: use of undeclared identifier 'OPENSSL_VERSION_STR'
ROCKY_ABOUT(openssl, OPENSSL_VERSION_STR)
from rocky.
The job
and job_scheduler
class must be separated, because of circular dependencies? Or should at least the job::dispatch
implementation be moved to Threading.cpp
?
from rocky.
Remo, I feel like many of these issues are just templates being instantiated before they are used. Is there some king of clang option for this? Because it isn't a problem on MSVC. Don't know about GCC.
I made another push to (hopefully) address these latest ones.
from rocky.
I haven't found a clang option to configure template instancing. Currently, I'm able to compile the project with my additional PR. But it need more work to link and run it.
from rocky.
Related Issues (20)
- Error: Did you set ROCKY_FILE_PATH to point at the rocky share folder? HOT 5
- can't link without zlib using disabled MBTiles and GDAL HOT 1
- Can rocky acess tms service provided by geoserver HOT 3
- Initial Download HOT 2
- Crash Line String Relative HOT 1
- Loading Terrain Crash HOT 1
- Immediate Hang At Start Up HOT 2
- random crash in rocky while zooming and panning HOT 12
- compile error with c++20 HOT 4
- "The ordinal 125 could not be located in... gdlad.dll" HOT 5
- error: building pkgconf:x64-windows failed with: BUILD_FAILED HOT 1
- vcpkg building VSG error
- Assertions cause forced exit after any MapNode or SkyNode is destroyed.
- Replace NVIDIA-specific barycentric extension with vendor-neutral version
- Infinite recursion in rocky::MapManipulator HOT 1
- Inf/NaN in shader HOT 2
- Do you have plans to support MVT HOT 1
- White regions in map where data is intermittently unavailable HOT 2
- Cannot find the shaders HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocky.