Git Product home page Git Product logo

Comments (12)

hildjj avatar hildjj commented on July 19, 2024 1

Once you make the rollup change, anything browserify should be moot, I hope.

from peggy.

hildjj avatar hildjj commented on July 19, 2024

Nod. I use this as a pre-test before pushing. CI is doing 10,12,14,15, soon to move to 12,14,16,17.

Probably nobody but me should use this. That said, nve is cool, and supports the --parallel flag which I should have used here.

I wonder if there is a better way for me to store my personal scripts?

from peggy.

StoneCypher avatar StoneCypher commented on July 19, 2024

It's probably fine to have it as a side script, it just shouldn't be in the main build or main test path, because then it's a practical dependency

Like if this was just named test:node_extra and there was a test:node that used the default version, and nve was made an optional dependency, that'd probably be it, finished

I might advocate that you consider the likelihood that regression behavior in older versions is sufficiently unlikely that, given that the CI rig will be publishing numbered builds, it can't get through either way, and you could be reducing your labor to waiting on the GH interface to say "passed"

I mean if you want this, go ahead, it's not hurting anybody once it's optional and out of the main path

But I suspect you're spending more time than you need to

from peggy.

hildjj avatar hildjj commented on July 19, 2024

Nod. Once we've got the rollup path in, I probably won't use this anymore. Next time I'm in there, i'll remove it.

from peggy.

StoneCypher avatar StoneCypher commented on July 19, 2024

I'll be doing that this weekend, sorry for the delay

from peggy.

Mingun avatar Mingun commented on July 19, 2024

@StoneCypher , are you using Windows or Linux? Because on the Windows bin/peggy from npm run parser task don't run :( :

> npm test

> [email protected] pretest
> npm run parser


> [email protected] parser
> bin/peggy -o lib/parser.js --format commonjs src/parser.pegjs

"bin" не является внутренней или внешней
командой, исполняемой программой или пакетным файлом.

I'm will be glad to you if you take into account this problem...

from peggy.

hildjj avatar hildjj commented on July 19, 2024

I never work on this stuff on Windows, so if you want to send a small patch to run peggy correctly, I'll take it. Actually, that's pretty important to me, because I'd like our project to be an example for folks who want to use Peggy in their own projects.

from peggy.

hildjj avatar hildjj commented on July 19, 2024

I removed the nve references in #89, but I'm going to leave this open with the new title "Make scripts work on Windows"

from peggy.

StoneCypher avatar StoneCypher commented on July 19, 2024

So I made the scripts work on windows, but that in turn shows that the browserify setup isn't portable

Would you mind if I fix this and rollup at the same time? That's pretty gross, I admit, but it'd help given the wedge

from peggy.

StoneCypher avatar StoneCypher commented on July 19, 2024

image

from peggy.

StoneCypher avatar StoneCypher commented on July 19, 2024

or actually

i could just treat them as separate bugs, that's silly

nevermind

from peggy.

StoneCypher avatar StoneCypher commented on July 19, 2024

should be

from peggy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.