Allow mounting into express.js application about peerjs-server HOT 13 CLOSED

Plus 1 for this ticket
I definitely Agree with halfdan's comment.

from peerjs-server.

I think PeerServer should extend restify object to enable this feature (instead of keeping it in this._app. Also this will allow export application object to grunt-express-server.

from peerjs-server.

After some searching around - turns out, that restify can't be used with express.

from peerjs-server.

@floatdrop there is express-resource which should allow doing similar things as restify with Express

from peerjs-server.

@bergie yes, there is. I would write a pull-request to migrate from restify to express, but I don't know about repo owners thoughts on it.

from peerjs-server.

I'm very positive on moving from restify to express!

from peerjs-server.

As I mentioned in a separate thread, we actually switched FROM express to
restify. Happy to consider switching back.

Michelle

On Thu, Apr 3, 2014 at 7:27 AM, Fabian Becker [email protected]:

I'm very positive on moving from restify to express!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-39457213
.

from peerjs-server.

Any progress on this?
Maybe allowing the PeerJS server to be mounted on just a regular HTTP Server instance?

from peerjs-server.

Looking forward for this too !

from peerjs-server.

Can't wait 👍

from peerjs-server.

Sorry for the delay on this--I'll try to get out an expressjs peer server this weekend.

from peerjs-server.

To fix request.query for expressjs I use this express workaround:

expressApp.use(function(req, res, next){
  req.query = null;
  next();
})

the middlware should be first in express.

from peerjs-server.

Hi, how's it going with migration?

from peerjs-server.