Git Product home page Git Product logo

Comments (7)

AlexZeitler avatar AlexZeitler commented on July 29, 2024

As can be seen in #45 3.4 broke the tests.
Using nginx:alpine would be fine but we need to make the start blocking then.

from docker-compose.

Steveb-p avatar Steveb-p commented on July 29, 2024

I'd say we should pin to a specific version anyway to prevent such random test failures :)

Assertion in the test in question can also be "rephrased" to check for something else than OS name :) It is a test of docker-compose exec anyway :)

from docker-compose.

AlexZeitler avatar AlexZeitler commented on July 29, 2024

👍

from docker-compose.

AlexZeitler avatar AlexZeitler commented on July 29, 2024

The entry for nginx:alpine in docker-compose should contain this to be blocking:

command: nginx -g "daemon off"

from docker-compose.

Steveb-p avatar Steveb-p commented on July 29, 2024

@AlexZeitler I'll provide PR in the evening. Had a few days off due to holidays & being busy at work.

from docker-compose.

AlexZeitler avatar AlexZeitler commented on July 29, 2024

👍 Take your time

from docker-compose.

Steveb-p avatar Steveb-p commented on July 29, 2024

Intentionally left Nginx with Debian as OS for your checkOS tests.

Also, is there any particular reason for tape as test framework? I'm not really familiar with it, but it doesn't seem to be "vocal" about which tests exactly did not pass and it's kinda a hurdle to look through output to see :) Not to mention not really being able to filter tests to only run those I'm interested in (I didn't really look too much into it, just curious).

from docker-compose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.