pdfkit --install-wkhtmltopdf doesn't work well with rvm (no patch included... yet) about pdfkit HOT 7 CLOSED

there you go: http://github.com/grosser/PDFKit/commit/11dadca2ca0ed85c3dc5e653f62f296a863d37a9

from pdfkit.

That little beauty does install it where rvm likes to put binaries, but pdfkit is still hard-coded to the system location, and so rake spec fails too.

from pdfkit.

oops i overlooked that, in my branch its still just 'wkhtmltopdf', is there a reason why it was hardcoded ?
if there is then it should be something like
executable = File.exist?(hardcoded) ? hardcoded : 'wkhtmltopdf'

from pdfkit.

Something like that http://github.com/grosser/PDFKit/commit/84ff40940c1a002e6e2bf1db998fe0ea2c996521

from pdfkit.

the only reason I can think of is some may consider it a security concern to not hard code every path to every executable in a production system... but others may consider this concern pretty minor, since you have to be broken in pretty far to affect it anyway.

from pdfkit.

if someone can alter your PATH your screwed anyway...

from pdfkit.

Hey guys,

I pulled Grosser's changes in and released v0.4.2.

Dburry, if you are worried about referring to wkhtmltopdf directly on your path, you can always point PDFKit to the binary by doing:

PDFKit.configure do |config|
config.wkhtmltopdf = '/path/to/wkhtmltopdf'
end

Jared

from pdfkit.