Time units mismatch about hawknet HOT 9 CLOSED

Another option is to just change the ConvertToUnixTimestamp method to return TotalMilliseconds but it would keep all the aritmetic operations.

from hawknet.

I seems to have encountered the same issue, but only when using dflydev-hawk to talk to hawknet, but not from hawknet to hawknet. Just thought I'd ask in case this is indeed a confirmed issue.

from hawknet.

hawknet makes is coherent (despite wrong) when generating and verifying the bewit. That's why you may not notice the behavior when using only hawknet.

from hawknet.

Thanks for the explanation! Would it be sensible for me to create a fork version with the fix and base our solution off that? Or have you encounter other solutions?

from hawknet.

I made the fix locally because I had to make this work quickly. I think you could do it and submit a pull request to pcibraro.

from hawknet.

I am very sorry guys. I have been out for the last few days and I somehow missed this thread. Luis, feel free to send me a pull request with the fix and I will push it in the repository as soon as possible. Thanks

from hawknet.

Thanks @luisgoncalves and @pcibraro!

from hawknet.

Would this latest change be pushed into NuGet?

from hawknet.

It has been pushed today. Version 1.3.1.0. Thanks

from hawknet.