Comments (5)
Brickner[CodePlex]
If you can show me a case where the bug shows, I'll try and fix it.
I can't find the bug and my test passes, so I will close this issue if there's no more information...
from pcap.net.
Brickner[CodePlex]
I've written this test:
[TestMethod]
public void IpV4LayerChecksumBytesNotErasedIfHeaderChecksumSetToNullBugTest()
{
Packet packet = PacketBuilder.Build(DateTime.Now,
new EthernetLayer(),
new IpV4Layer(),
new TcpLayer());
var ipLayer = (IpV4Layer)packet.Ethernet.IpV4.ExtractLayer();
ipLayer.Destination = new IpV4Address(1.2.3.4);
ipLayer.HeaderChecksum = null;
packet = PacketBuilder.Build(DateTime.Now,
new EthernetLayer(),
ipLayer,
new TcpLayer());
Assert.IsTrue(packet.Ethernet.IpV4.IsHeaderChecksumCorrect);
}
And it passes.
What is the bug?
from pcap.net.
Brickner[CodePlex]
When I look back at this bug, I'm not sure in which case would the buffer will have non-zero values in the header checksum offset.
PacketBuilder creates a new buffer (with all zeros), so why would the buffer have non-zero values in the header checksum offset?
from pcap.net.
Brickner[CodePlex]
I've looked at the code and it seems you're right.
I think a better fix is when calculating the checksum to simply ignore the bytes that represent the checksum instead of zeroing them.
Will be fixed.
from pcap.net.
Opera362[CodePlex]
I have also created 7663 patch (and uploaded to source code)
from pcap.net.
Related Issues (20)
- Does it support EtherCAT frame filter? HOT 1
- Incorrect device description compared to dumpcap -D, tshark -D output HOT 1
- "System.InvalidOperationException" in PcapDotNet.Core.dll: No interfaces found HOT 1
- NullReferenceException when trying to access UDP ports? HOT 2
- How do I can parse HTTP request? HOT 1
- When Sending TCP Packets using PCAP.NET the TCP Options are not visible on Wireshark? My goal is actually to maniupulate the Selective Acknowledgement option... but I can't even see the options to begin with. HOT 1
- How to stop send packet? (Trasmit()) HOT 1
- Npcap support HOT 3
- pcap.h not found compile time on PcapDotNet.Core module HOT 2
- System.BadImageFormatException: Could not load file or assembly 'PcapDotNet.Core.dll' HOT 1
- Add support for Win10PCap library
- Datasegment.cs not found, StackoverflowException
- Creating Dump File Does Not Work
- Send packet on linux HOT 1
- Weird IP And Ports HOT 1
- Is it possible to use Pcap.Net to do IP Address Spoofing for websocket's in C#? HOT 2
- Capture packet from another IP within the same network
- Packet Send Without Network
- Forcing a process to communicate through the proxy
- support for NSEC_TCPDUMP_MAGIC is missing in version 1.0.4.1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pcap.net.