Git Product home page Git Product logo

Comments (4)

pbatard avatar pbatard commented on August 16, 2024

Thanks Andrey.

  1. Good point. libwdi/git was hosted on sourceforge prior to that, so that wasn't an issue. Now, my problem is I use the export-ignore because I use git export when generating the official source tarballs, and I don't want them to contain autogen.sh, since configure will have been generated. I'll try to figure out something to keep both git tarball and officiall tarball users happy.
  2. There are good default arguments to configure: the ones I use on my development platform! So these are the ones I set as default. If I didn't do that, I'd have to run configure manually, and with autotools being so slow on Windows compared to Linux (about 10x slower!), I want to have a one "run and forget" command that will get me to the makefile. But I understand your point, and the way we solved that for libusbx (where a similar case was made) was to have both a bootstrap.sh, that doesn't invoke configure, and an an autogen.sh that does. I'm planning to do the same for libwdi.
  3. I'll look into it, but I want to make sure this won't create issue on MinGW. By the way, if you feel like sending a patch for that, I'll be more than happy to test and apply it.

I'll keep this issue open for now, and close it once the 3 issues you mentioned have been addressed. Thanks a lot for the report!

from libwdi.

andreygursky avatar andreygursky commented on August 16, 2024

Yeah, bootstrap.sh for other is what we need.

and with autotools being so slow on Windows compared to Linux (about 10x slower!)

I think it is because it invokes compiler and even worse linker for almost every check, isn't it?

Regarding 3, here is a better proposal:

AC_ARG_WITH([libusb0],
    [AS_HELP_STRING([--with-libusb0], [embed libusb0 driver files from the following location])],
-   [LIBUSB0_DIR=$withval],
+        [case "$withval" in
+#in case of absolute path, leave it as is
+                /* | [[A-Za-z]]:[[\\/]]*) LIBUSB0_DIR="$withval"
+                        ;;
+#we're in the top_builddir, but LIBUSB0_DIR is used from from $top_builddir/libwdi,
+#that's why if the given path is relative, it should be prepended with ..
+                *) LIBUSB0_DIR="../$withval"
+                        ;;
+         esac],
    [LIBUSB0_DIR=""])
if test "x$LIBUSB0_DIR" != "x"; then
    AC_DEFINE_UNQUOTED([LIBUSB0_DIR], ["${LIBUSB0_DIR}"], [embed libusb0 driver files from the following location])
fi

from libwdi.

pbatard avatar pbatard commented on August 16, 2024

Thanks. I'll try to integrate your patch (which looks OK to me at first glance) as soon as I can, but it might take a few weeks before I am able to do so.

from libwdi.

pbatard avatar pbatard commented on August 16, 2024

For the record, I have added a bootstrap.sh in 9a40253. That should take care of step 2. I'll try to deal with 3. soon...ish. 1. might be a while.

from libwdi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.