What-changed CompareDocuments panics about libopenapi HOT 5 CLOSED

I will investigate, thanks for finding this.

from libopenapi.

Found a possible cause on https://github.com/pb33f/libopenapi/blob/main/what-changed/model/example.go#L73.

The Tag of the Value is not taken in to account. !!timestamp vs !!str.

I will create a PR.

from libopenapi.

This is not fixed with my fix in #62.

The test case didn't include a map as a value:

value:
  map:
    date: 2022-12-29`

The changes := CompareExamples(&lDoc, &rDoc) returns nil. In places where it is used, there is no nil check: https://github.com/pb33f/libopenapi/blob/main/what-changed/model/media_type.go#L26

It is assigned by CheckMapForChangesWithComp on https://github.com/pb33f/libopenapi/blob/main/what-changed/model/comparison_functions.go#L253.

So there are a few places where it can break and this might not only be related to examples.

from libopenapi.

I will check for other instances of this issue.

from libopenapi.

This is an isolated incident; after reviewing the other models, examples are the only place where this type of comparison is performed. The glitch was a nil reference being added to the resulting map, as you detected, the code now performs a check before adding the results, and examples that use complex shapes are now hashed for comparison. The fix is in #65

from libopenapi.