Comments (4)
Thanks for your report. Yes a PR would be much appreciated :) Please separate code and documentation in different PRs of course. Just came back from holidays, lot of work to catch up ^^
from django-zxcvbn-password.
Hi -
I actually ended up doing a more manual implementation of zxcvbn rather than using this library. So since I'm not using it, am probably not the best person to do the PR after all. Should be an easy doc tweak though. Thanks!
from django-zxcvbn-password.
So, to get back at this:
- doc about adding
zxcvbn_password
inINSTALLED_APPS
: done thanks to @beruic - note about upstream docs: I will remove this note since it does not seem to be helpful
- note about
form.media
: I will update this note to be more clear: including{{ form.media }}
in the JS block of your template will in fact include media from all form's fields and widgets. In this app, the only declared media is in thePasswordStrengthInput
widget. - colors not working: indeed the JS code relies on jquery and bootstrap 😕 I will add a note about these requirements in the README.
- guidance about Django's
set_password
: it's an example among many others, I personally don't useset_password
. Usually you justUser.objects.create(username=..., password=...)
withusername
andpassword
retrieved from the form cleaned data.
from django-zxcvbn-password.
Thanks @shacker for your feedback!
from django-zxcvbn-password.
Related Issues (13)
- JS code dictionaries HOT 1
- Django 1.8 LTS HOT 2
- Color indicator HOT 3
- Confusing help_text HOT 12
- Initial Update
- Release 2.0.1 to pypi? HOT 2
- Bootstrap 4 classes HOT 2
- Allow a customizable warning message with variables HOT 2
- Use updated zxcvbn python library. HOT 7
- Using deprecated dependency HOT 4
- Stop using client-side validation javascript code HOT 1
- getting a syntax error on 2.1.0 with python 2.7.12 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-zxcvbn-password.