translateX offset, image disappear on pan about react-native-awesome-gallery HOT 4 CLOSED

Quick demo of the issue:

from react-native-awesome-gallery.

I've found the first issue (offset on translateX) caused by the containerDimensions.x being rounded (338 instead of 338.825), linked to my code

The second issue is weirder though I'm not sure what's causing this exactly:
It seems that the layout.x.value is NaN when panGesture start. which result in getEdgeX returning a NaN and image then disappear. The thing is that the image did appear, so the layout has the correct dimension set.

A quick fix is to check for NaN:

    const getEdgeX = () => {
      'worklet';
      const newWidth = scale.value * layout.x.value;

      const point = (newWidth - width) / 2;

      if (point < 0 || isNaN(newWidth)) {
        return [-0, 0];
      }

      return [-point, point];
    };

@pavelbabenko let me know if you think it is a good idea so I can submit a PR.

from react-native-awesome-gallery.

Released in v0.3.6

from react-native-awesome-gallery.

Thanks for taking care of this.
I would have liked to have been included in the mention, as right now, my contribution is disregarded in the final work.

from react-native-awesome-gallery.