Comments (4)
paupino
commented on August 21, 2024
1
I've discovered the bug: it's in the division routine whereby we get an underflow in the division however don't attempt to resolve it there. I understand the problem now so will look to get out a solution as soon as I can. This is a shared issue in both simply because division silently allows invalid scales at the moment.
from rust-decimal.
paupino
commented on August 21, 2024
I think this is due to an incorrect assumption I made in terms of underflow vs rounding (i.e. here https://github.com/paupino/rust-decimal/blob/master/src/decimal.rs#L1624). Let me reproduce this in a test and see what I can do to fix it.
from rust-decimal.
paupino
commented on August 21, 2024
(i.e. We're not losing precision if they're 0's)
from rust-decimal.
rkusa
commented on August 21, 2024
Wow, Thanks a lot @paupino for investigating and fixing the issue!
from rust-decimal.
Related Issues (20)
- `serde-arbitrary-precision` without `serde-float` HOT 7
- `is_integer` has BUG HOT 1
- How to serialize Decimal and still keep the results in order (bitwise comparison) HOT 3
- Serialization V2 - brainstorming HOT 1
- feature request: JSON schema support via https://github.com/GREsau/schemars HOT 1
- Feature Request: Support wasm_bindgen for Decimal
- rlp (de)serialization? HOT 2
- Rust Decimal: Request for additional repository Owner/Collaborator(s) HOT 1
- Rescaling a value with significant scale 28 to scale 29 creates a value with scale 29 and overflows on subtraction HOT 1
- Support for mongo HOT 2
- To f64 losing accuracy for `100000.000000000000000000` HOT 1
- Scaling string representation differs from dividing by 10^x HOT 4
- too rubbish to called rust decimal HOT 3
- checked_powd takes exponentially long time to complete HOT 6
- Scale changes unexpectedly after operations HOT 3
- 1.34.0 breaks with cyclic dependency when installed with "macros" feature HOT 4
- Deserializing `Decimal`s from Postgres using the `db-postgres` feature can lead to invalid `Decimal` instances HOT 4
- Bug: not 128bit aligned with `repr-c` feature HOT 3
- Return error rather than panic in `FromSql` when overflow HOT 1
- Bug: Decimal::from_sql incorrectly transforms Postgres NaN to 0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-decimal.