Git Product home page Git Product logo

Comments (6)

paupino avatar paupino commented on August 21, 2024 1

I've now set it up so that PR's into master require TravisCI builds to pass. Now that TravisCI builds do pass I think we can close this issue.

from rust-decimal.

paupino avatar paupino commented on August 21, 2024

We could also add a PR webhook here so that only PR's that pass the build check can be merged. I'm more inclined to do that and continue using tags for releases than using develop however am open for discussion here. By the way, the master branch is currently protected against force merges etc so a PR is (now) required in order to get something into master (hence why the PR webhook could work).

from rust-decimal.

JP-Ellis avatar JP-Ellis commented on August 21, 2024

I would definitely set up Github to refuse pull requests until they pass the CI tests; then it's up to you whether you want to use a develop branch. It's always possible to create new branches as need be.

from rust-decimal.

paupino avatar paupino commented on August 21, 2024

Also, have added to the Readme page.

from rust-decimal.

paupino avatar paupino commented on August 21, 2024

I'm new to using Travis so I may have set this up incorrectly for forks. Is it expected that you'd need to authorize your fork on Travis also @JP-Ellis ?

from rust-decimal.

paupino avatar paupino commented on August 21, 2024

Nope, nevermind. Travis just requires conflicts to be resolved first. All good.

from rust-decimal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.