Git Product home page Git Product logo

Comments (6)

paulmillr avatar paulmillr commented on July 30, 2024 1

0.5.3

from noble-ciphers.

paulmillr avatar paulmillr commented on July 30, 2024

5bce492

from noble-ciphers.

paulmillr avatar paulmillr commented on July 30, 2024

as for secretstream - i don't think it's very popular, but documenting a way to encrypt huge files would be useful for README.

from noble-ciphers.

ainsly avatar ainsly commented on July 30, 2024

Quick turnaround dude, thanks!

And you're right about secretstream, only discovered it not too long ago. The motivation was less about huge files and more about configurable chunking to counteract the limitations of the stream cipher, although that's definitely a plus.

But I'll hopefully be able to get around to an implementation of it using noble for an entry in the readme. Will keep you posted 🙏🏽 thanks again for that quick release

from noble-ciphers.

ainsly avatar ainsly commented on July 30, 2024

@paulmillr not sure how esbuild didn't pick this up before, but _arx isn't set in the package exports...

The path "./_arx" is not exported by package "@noble/ciphers":

    node_modules/@noble/ciphers/package.json:35:13:
      35 │   "exports": {
         ╵              ^

  You can mark the path "@noble/ciphers/_arx" as external to exclude it from the bundle, which will remove this error and leave the unresolved path in the bundle.

Not sure you're too keen on exposing too much to the public api, seeing as though the file's marked as pseudo private with the _ prefix.

But on the other hand it would expose the internal createCipher method to enable more customised usage.

Or could just re-export from the utils export, maybe aliased to not cause confusion.

Either way is fine with me, but depends what you think is best.

If neither option is good it's fine I can just switch back to constant, seeing as though it literally is just a constant.. guess it was just a QOL improvement.

LMK your thoughts

from noble-ciphers.

paulmillr avatar paulmillr commented on July 30, 2024

«But on the other hand it would expose the internal createCipher method to enable more customised usage»

what’s the use case?

from noble-ciphers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.