Math.log10 about es6-shim HOT 11 CLOSED

Do you propose to round the result?

The function uses just built-in js math funcs: Math.log(1e15) * 1 / Math.LN10 gives the same result.

from es6-shim.

rounding will not help

users of this shim should be informed...

from es6-shim.

I've added accuracy is 1e-11 to the readme.

from es6-shim.

how did you calculate this accuracy?

from es6-shim.

It's simple, it's the smallest accuracy when all math tests are passing.

from es6-shim.

Math.hypot(10e200, 0) - 10e200

from es6-shim.

and this is a bug in hypot. it should be probably for large numbers

function(x, y) {
  return Math.sqrt(x) * Math.sqrt(x) + Math.sqrt(y) * Math.sqrt(y);
};

from es6-shim.

meh, it gives incorrect result too

from es6-shim.

@paulmillr see https://gist.github.com/2427837 for "hypot" - http://www.netlib.org/fdlibm/e_hypot.c translated to js

from es6-shim.

great, thanks, i'll look at it & try to merge

from es6-shim.

nice

from es6-shim.