Comments (3)
Hey @weslleyaraujo, thanks for the feedback!
This is the expected behavior, but morphdom
should probably report an error to the user. What's happening behind the scenes is that morphdom
is parsing the HTML provided as the second argument using createContextualFragment(html)
and then it is picking only the first child as the target node:
Line 53 in ecde8f4
If the parsing of the contextual fragment results in multiple child nodes then that is really bad input for the current implementation of morphdom
.
The fact that there is a comment node doesn't really matter in this case. While it might solve your issue to skip over the comment nodes, I am not sure that is the right solution.
Hopefully you can update your code accordingly? If you have any thoughts or concerns please share, but for now I am going to go ahead and close the issue. While we could throw an error if there are multiple child nodes, that could potentially be a breaking change and we would need to up the major version and I want to avoid doing that for now.
from morphdom.
Thanks for the insights!
I think that some kind of warning/error would be very useful in this case,
the example above was just a test that I was doing to check... but back in a real world project, I took quite long to find out what was happening.
I think this might be something to add on the roadmap for the next major release,
thanks once again!
from morphdom.
he example above was just a test that I was doing to check... but back in a real world project, I took quite long to find out what was happening.
@weslleyaraujo @patrick-steele-idem Do you remember how to solve it? Same this is happening to me and I don't know how to solve it.
from morphdom.
Related Issues (20)
- examples don't work in macOS Chrome or Safari
- Input type change breaks value change
- onAfterChanges option (or something similar) HOT 7
- Allow to provide custom morphAttrs function
- Morphing page with a lot (1000 or so) FORM tags is slow
- Leverage the DocumentFragment API?
- Cannot read properties of null (reading 'nodeName')
- Is this project discontinued? HOT 1
- getNodeKey with text nodes isn't supported?
- Add style attribute condition for compat with CSP: unsafe-inline style
- Could we introduce a jsconfig.json
- documentation: add how to use it with HTML streaming
- Breaks on funny/broken HTML
- Morphdom Support for Template Elements
- export morphAttrs
- morphAttrs should handle only elements
- bug: when a document fragment is passed as toNode only the first child is used
- Testing morphdom with jsdom is tricky. HOT 2
- Outdated docs on `getNodeKey`?
- Optimization recommendation in README is a hazard and should be removed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from morphdom.