Git Product home page Git Product logo

Comments (5)

tbranyen avatar tbranyen commented on September 22, 2024

After more testing it appears that the children are diffed, but the parent container is removed. Either way my demo for a virtual-list module should work with morphdom. You get a container element and a fragment and need to merge the childNodes of both.

from morphdom.

AutoSponge avatar AutoSponge commented on September 22, 2024

I'm pretty sure you just need to use the childrenOnly flag in the options parameter.

from morphdom.

patrick-steele-idem avatar patrick-steele-idem commented on September 22, 2024

I do think we should properly handle a document fragment, but I'm not quite sure what the "correct" behavior should be when a document fragment is provided:

  • Are you intending on diffing just the child nodes of the source element with the child nodes of the target document fragment?
  • Should we diff the source node with the first child of the target document fragment?
  • What if there are multiple child nodes in the target document fragment?

It's easy enough to use the first child if the target is a document fragment, but that might not be expected. @tbranyen, what do you think the correct way to handle a document fragment as the target? Thanks for bringing this issue up and sorry for being slow to respond (I was out of the office last week).

from morphdom.

AutoSponge avatar AutoSponge commented on September 22, 2024

I posted a render function that should work for your documentFragment use.

https://github.com/AutoSponge/morphdom-render

from morphdom.

snewcomer avatar snewcomer commented on September 22, 2024

This is now supported!

3b70216

from morphdom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.