Comments (5)
Hi @kesne, morphdom uses the "id" attribute as the "key" by design. That is, morphdom works best if there are stable IDs for HTML elements and it will take extra steps to match up elements with matching IDs that are found in both the old DOM and the new DOM. Is there something else that you think is still missing?
from morphdom.
Ah, probably would have been good to read through the source before making an issue! My mistake.
I guess the only callout is that the benefit of a key design is that keys can be re-used in two different trees that you're running through morphdom, whereas IDs need to be absolutely unique.
from morphdom.
True. With Marko Widgets we have a strategy for ensure IDs are always unique by prefixing IDs with the ID of the parent widget. That trick has worked really well for Marko Widgets. For rendering lists of items we recommend using the index of the current iteration prefixed with the ID of the parent widget as the unique ID. If you have any other thoughts or suggestions please share!
from morphdom.
Yeah it's not really an issue with my use cases, I just thought I would call it out.
Feel free to close the issue if you're fine with the state of things.
from morphdom.
Sounds good. I will close this issue, but we can always reevaluate later. Thanks.
from morphdom.
Related Issues (20)
- examples don't work in macOS Chrome or Safari
- Input type change breaks value change
- onAfterChanges option (or something similar) HOT 7
- Allow to provide custom morphAttrs function
- Morphing page with a lot (1000 or so) FORM tags is slow
- Leverage the DocumentFragment API?
- Cannot read properties of null (reading 'nodeName')
- Is this project discontinued? HOT 1
- getNodeKey with text nodes isn't supported?
- Add style attribute condition for compat with CSP: unsafe-inline style
- Could we introduce a jsconfig.json
- documentation: add how to use it with HTML streaming
- Breaks on funny/broken HTML
- Morphdom Support for Template Elements
- export morphAttrs
- morphAttrs should handle only elements
- bug: when a document fragment is passed as toNode only the first child is used
- Testing morphdom with jsdom is tricky. HOT 2
- Outdated docs on `getNodeKey`?
- Optimization recommendation in README is a hazard and should be removed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from morphdom.