Git Product home page Git Product logo

Comments (12)

pashky avatar pashky commented on June 30, 2024

And that's kids why you don't merge pull requests blindly. Should be fixed now, please update and thanks for heads up.

from restclient.el.

magnars avatar magnars commented on June 30, 2024

Ack! This was my fault? I even tried without any variables right now, and for some reason that worked.

Sorry about that.

from restclient.el.

magnars avatar magnars commented on June 30, 2024

Aha, my version of regexp-opt creates a "" instead of nil when given an empty list. Must be differing versions of Emacs.

from restclient.el.

julienXX avatar julienXX commented on June 30, 2024

I'm using 24.3 on OSX if that can be of any help.

from restclient.el.

magnars avatar magnars commented on June 30, 2024

Same here. What does M-: (regexp-opt nil) say?

from restclient.el.

pashky avatar pashky commented on June 30, 2024

No worries. May be emacs version diffs, yes.

Th issue is not in regexp-opt, but in replacement function. Apparently, it tries to replace every empty space with nil and fails. Try this (replace-regexp-in-string "" (lambda (key) nil) "blah") - does it work?

Mine is:
GNU Emacs 24.3.1 (x86_64-apple-darwin, NS apple-appkit-1038.36) of 2013-03-11 on bob.porkrind.org

from restclient.el.

julienXX avatar julienXX commented on June 30, 2024

@magnars it says ""

from restclient.el.

julienXX avatar julienXX commented on June 30, 2024

@pashky doesn't work for me in a scratch buffer

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
replace-match(nil nil nil "b" nil)
replace-regexp-in-string("" (lambda (key) nil) "blah")
eval((replace-regexp-in-string "" (lambda (key) nil) "blah") nil)
eval-last-sexp-1(t)
eval-last-sexp(t)
eval-print-last-sexp()
call-interactively(eval-print-last-sexp nil nil)

from restclient.el.

magnars avatar magnars commented on June 30, 2024

Aha, look at that. Yes indeed, when there are no vars it will try to replace everything with nil. My testing was bad, since I had two versions of restclient installed, and the old one trumped the new one.

Thanks for the fix, @pashky.

from restclient.el.

magnars avatar magnars commented on June 30, 2024

And sorry for wasting both of your times with bad patches!

from restclient.el.

pashky avatar pashky commented on June 30, 2024

No problem really :)

from restclient.el.

julienXX avatar julienXX commented on June 30, 2024

No worries, I tried to fix the issue myself but I suck too much at elisp :)

from restclient.el.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.