Empty structs generates invalid Go code about colfer HOT 4 CLOSED

B.t.w., you can just type colf go (instead of colf Go test.colf) if you want to. The documentation is a bit fuzzy there. 😅

from colfer.

Hello, @pascaldekloe. Thank you for the quick answer.
However, I was under the impression that empty struct were valid values to be used with colfer.
I found this bug, because I was using colfer in a Go project with empty structs, mainly as acknowledges for some remote procedure calls.
Although the generated code was invalid, removing the unused eof label allowed it to compile and function correctly, as far as i could test.
Would it be possible to revert this change, and allow empty structs to be accepted in colfer? Is there any shortcoming of using empty struct with colfer?

from colfer.

Thank you for the detailed report Vítor. Somehow the non-empty check got lost. I will add it back again.

from colfer.

The empty struct encodes as a fixed single byte (0x7F). It encodes no information. Therefore I think it should not be used.

Why do you encode an acknowledge response? A zero byte payload is Colter's concept of NULL, regardless of the type. Wouldn't it be better to make your RPC setup skip NULL submission, and read zero payload as NULL again?

from colfer.