Comments (6)
Absolutely. When we try to add Smart Links to a Classic Block, it will not allow selecting the individual block, per the video below. This is the behaviour for all unsupported blocks.
Screen.Recording.2024-07-26.at.13.43.34.mov
If we try to generate Smart Links for the full content, unsupported blocks, such as the Classic Block, will be ignored.
from wp-parsely.
When the "All Blocks" setting is selected, we could consider removing Classic Blocks and submit the rest of the content. Noting though that this could result in suboptimal results, and that implementation might be tricky.
The issue that I see with that - I tried something similar - is that the offsets returned by the Content Suggestions API will not match the actual content offsets. It should be possible to make it work by ignoring the classc blocks when processing the Smart Links suggestions, but it's definitely not trivial.
from wp-parsely.
Thanks for the info! In this case, I think that just having a better error message for the second case should be enough.
from wp-parsely.
@vaurdan, does this issue get invalidated by #2673, partly or completely?
from wp-parsely.
Ah yes, it does! Good catch!
from wp-parsely.
For posterity, can you give a brief description here of what will happen in the 2 cases?
from wp-parsely.
Related Issues (20)
- Release wp-parsely 3.16.0
- ESLint: Enable the method-signature-style rule HOT 4
- Extract options functionality to a new class
- Consider polyfill solution to allow wp-scripts upgrades HOT 1
- Smart Linking: Empty Review Smart Links modal
- Smart Linking: Review modal alters styling in PCH Sidebar
- PCH: include AI label in AI-powered features HOT 2
- UTMs blocking ability for customer to export report data
- Release wp-parsely 3.16.1
- Fix Gutenberg deprecation warnings
- Smart Linking should not suggest links inside headings/captions
- Release wp-parsely 3.16.2 HOT 1
- PCH: ability to filter Related Posts by multiple Sections HOT 1
- PCH: show me performance data points on suggested smart links
- PCH: let me preview a smart link recommendation from the review modal HOT 1
- Errors when editing widgets inside of Customizer HOT 5
- Release wp-parsely 3.16.3
- Smart Linking: Implement "Apply to selection" mode HOT 4
- Excerpt Suggestions: Allow different personas/styles HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-parsely.