PCH Smart Linking: Improve Classic Block handling about wp-parsely HOT 6 CLOSED

Absolutely. When we try to add Smart Links to a Classic Block, it will not allow selecting the individual block, per the video below. This is the behaviour for all unsupported blocks.

If we try to generate Smart Links for the full content, unsupported blocks, such as the Classic Block, will be ignored.

from wp-parsely.

When the "All Blocks" setting is selected, we could consider removing Classic Blocks and submit the rest of the content. Noting though that this could result in suboptimal results, and that implementation might be tricky.

The issue that I see with that - I tried something similar - is that the offsets returned by the Content Suggestions API will not match the actual content offsets. It should be possible to make it work by ignoring the classc blocks when processing the Smart Links suggestions, but it's definitely not trivial.

from wp-parsely.

Thanks for the info! In this case, I think that just having a better error message for the second case should be enough.

from wp-parsely.

@vaurdan, does this issue get invalidated by #2673, partly or completely?

from wp-parsely.

Ah yes, it does! Good catch!

from wp-parsely.

For posterity, can you give a brief description here of what will happen in the 2 cases?

from wp-parsely.