Link to facebook alway successfull in case of got exception about parse-sdk-android HOT 10 CLOSED

This is working as intended. What you're seeing is that the user currently has Facebook auth data attached to it, but is currently in a dirty state as the request has failed.

You should update your callback as the request has only succeeded if e != null.

from parse-sdk-android.

When I check this function again ParseFacebookUtils.isLinked(user) in somewhere, it's return true, but currentUser not linked to any Facebook account, and currentUser don't have authData on parse.com

from parse-sdk-android.

The information isn't persisted on the server as your request failed, however, the ParseUser you have locally has the authData attached since it attempted to link to a Facebook account, but failed. Since it has it locally, ParseFacebookUtils.isLinked(user) will return true.

from parse-sdk-android.

Thank you for your feedback. We use the issues tracker here to track valid bugs in our SDK. Your question seems to be more about how to use Parse. Could you check out the following resources?

• Documentation: https://www.parse.com/docs
• Google Groups: https://groups.google.com/forum/#!forum/parse-developers
• Stack Overflow: http://stackoverflow.com/tags/parse.com

from parse-sdk-android.

This issue has not been updated for 7 days. If you have additional information to help pinpoint this issue as an SDK bug, please comment on this issue. We will close this issue in 7 days if no additional information is provided. Thank you for your feedback.

from parse-sdk-android.

We are closing this issue due to another 7 days of inactivity. If you have additional information to help pinpoint this issue as an SDK bug, please reopen it with the additional information.Thank you for your feedback.

from parse-sdk-android.

This behavior of ParseFacebookUtils library does not seem to be correct. Because this may produce inconsistencies in some cases as on server user is saved as Anonymous user whereas on device it is non-Anonymous user. So I think ParseFacebookUtils.isLinked(user) should return false after failed linking.
Also although I am an Android developer but I think on iOS platform, if this 208 error occurs, iOS version of this library does not start returning true for ParseFacebookUtils.isLinked(user) instead it returns false. This iOS sdk behavior seems consistent with the server state and I think same should be in Android.

For solutions, I tried to use persistent storage for tracking if user is actually not linked, which was overkill. Then I have managed to retain correct state by calling ParseFacebookUtils.unlink(user) for current user in case 208 error had occurred. I am not sure if this workaround is correct, but it seems to be working.

By the way even if this buggy behavior seems fine this should be mentioned in docs and sample codes.

It has possible workarounds, but I still think that library behavior needs to be changed.

from parse-sdk-android.

@grantland could you please help a little here.
Could this issue be reopened as suggested in my last comment, or should I create new issue for it, or is it not worth it?

from parse-sdk-android.

@SobanMahmood I tried to find some solution for this problem, Finally I called unlikFacebook account if I got error code 208 in response, I wrote some code like below:

List<String> permissions = Arrays.asList("public_profile", "email", "user_birthday");
ParseFacebookUtils.linkWithReadPermissionsInBackground(currentUser, getActivity(), permissions, new SaveCallback() {
    @Override
    public void done(ParseException e) {
        if (e != null) {
            // has error
            if (e.getCode() == 208) {
                ParseFacebookUtils.unlinkInBackground(ParseUser.getCurrentUser());
                MaterialDialogUtils.showOopsMaterialDialogs(getActivity(), "Another user is already linked to this facebook ID. Please try another FB account.");
            } else {
                MaterialDialogUtils.showOopsMaterialDialogs(getActivity(), "Can't link your account to FB. Code = " + e.getCode());
            }
        } else if (LoginHelper.isLinkedWithFacebook()) {
            // linked success
        }
    }
});

Hope it will help some one have same problem. :)

from parse-sdk-android.

Thank you @kenilt . That seems to be working. I am using the similar solution. For more consistency with future version changes, I have also included ParseFacebookUtils.isLinked(user) condition before calling unlink in case of error 208 like this.

            ...
            if (e.getCode() == 208) {
                if (ParseFacebookUtils.isLinked(ParseUser.getCurrentUser())) {
                    ParseFacebookUtils.unlinkInBackground(ParseUser.getCurrentUser());
                }
                MaterialDialogUtils.showOopsMaterialDialogs(getActivity(), "Another user is already linked to this facebook ID. Please try another FB account.");
            } else {
                MaterialDialogUtils.showOopsMaterialDialogs(getActivity(), "Can't link your account to FB. Code = " + e.getCode());
            }
            ...

from parse-sdk-android.