Comments (7)
parro-it
commented on May 18, 2024
Which version are you using?
from electron-localshortcut.
Eugeny
commented on May 18, 2024
The latest one from NPM
from electron-localshortcut.
parro-it
commented on May 18, 2024
It should be 2.0.2, but I cannot find the code you are describe. Could you point the exact version and line on GH?
from electron-localshortcut.
Eugeny
commented on May 18, 2024
accelerator is a string (typeof win === 'string'):
https://github.com/parro-it/electron-localshortcut/blob/master/index.js#L218
which then gets fed into _disableShortcut:
https://github.com/parro-it/electron-localshortcut/blob/master/index.js#L223
where it attempts to use an .accelerator property on the string:
https://github.com/parro-it/electron-localshortcut/blob/master/index.js#L22
from electron-localshortcut.
parro-it
commented on May 18, 2024
Got it, thank you, I'll correct it
from electron-localshortcut.
jianfei
commented on May 18, 2024
When will this be fixed?
Changing https://github.com/parro-it/electron-localshortcut/blob/master/index.js#L223 into _disableShortcut({ accelerator }); seems fixed this issue.
from electron-localshortcut.
parro-it
commented on May 18, 2024
Could you try with version 3.0.4? The problem should be solved in this last version.
from electron-localshortcut.
Related Issues (20)
- transparent window HOT 1
- Listen localshortcut only on window HOT 1
- On qwertz keyboard, "z" and "y" are triggered by both "z" and "y"
- Accelerator stopped working in v3 HOT 2
- Version 10 of node.js has been released
- Uncaught Exception: TypeError: str.split is not a function HOT 4
- An in-range update of electron is breaking the build 🚨 HOT 13
- An in-range update of debug is breaking the build 🚨 HOT 2
- An in-range update of delay is breaking the build 🚨 HOT 3
- Webview support HOT 1
- Prevent default event action HOT 4
- An in-range update of p-event is breaking the build 🚨 HOT 3
- Ctrl+Space is not working HOT 2
- unregisterAll(mainWindow) shows error HOT 4
- Do not work in the following environment HOT 1
- 3.2.0 Breaks electron-vue HOT 1
- 'PrintScreen' not working
- ctrl+e is not a valid accelerator - but works properly
- 'numadd', `numsub` are not valid accelerators - but they are HOT 3
- On azerty keyboard, "w" is triggered by both "w" and "z" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-localshortcut.