Comments (4)
from rust-cryptoki.
One downside to the API above the mutable borrow means it is not possible to interleave calls to find_next
with calls to other session operations. I think it's possible to recover that by adding a method session(&self) -> &Session
to FindObjects
. Since it only returns an & reference, it should be possible to do any other session operation except starting a new object search.
Also, I just realized that it would be necessary to change find_objects
to take a mutable reference as well, to prevent someone from calling find_objects
while another object search is ongoing. That would make this a breaking change.
from rust-cryptoki.
Another downside is that we can't handle errors from C_FindObjectsFinal
, since it's called from drop
. An alternative that would allow this is to use some sort of type-state: when we start a search, take the session by value, and then when you end the search you get the session back by value (only after checking for errors). One could still borrow a &Session during the search, to perform non-search operations.
I would consider this much less ergonomic than the API above. I doubt anyone cares much about handling errors from C_FindObjectsFinal
, since there's not much you can do besides closing the session and trying to open a new one.
from rust-cryptoki.
The use-case is good and I like your ideas. 👍
While looking at your proposed API it makes a striking resemblance to the Iterator API. Just wondering, have you considered providing an interface like this? Of course then you'd have to return Option<Result<ObjectHandle>>
(just like fallible iterators) and probably do some caching (so that FindObjects is not too frequently called).
PRs of course welcome! Sorry in advance for the delay in reviewing 🙇
from rust-cryptoki.
Related Issues (20)
- Missing constants for x86_64-unknown-linux-gnu HOT 6
- Function name as part of errors HOT 3
- CKA_PUBLIC_KEY_INFO getting TypeInvalid HOT 8
- Wrapper for C_WaitForSlotEvent HOT 5
- finalize() without drop()? HOT 1
- `clone()` and `is_initialized()` HOT 13
- bug: `is_fn_supported()` always returns `true` HOT 1
- UserNotLoggedIn calling decrypt after login.... HOT 5
- Signing and Verifying HOT 2
- PKCS OAEP padding always returns: Pkcs11(ArgumentsBad) HOT 3
- test slot::token_info::test::debug_info fails on 32-bit architectures. HOT 1
- Add Wycheproof-based tests
- Wasm support HOT 2
- session.login fails on MacOS Sonoma HOT 8
- New release? HOT 8
- PkcsOaepParams HOT 3
- Build of cryptoki v0.6.1 failing on Fedora 39+ HOT 23
- Cannot init_token using an HSM with PED
- Do not call C_Finalize if not initialized
- Add support for C_GetInterfaceList
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-cryptoki.