Git Product home page Git Product logo

Comments (11)

paragonie-scott avatar paragonie-scott commented on June 5, 2024

I'm worried this might be a Curve25519 bug, which is the slowest thing to test on 32-bit.

from sodium_compat.

paragonie-scott avatar paragonie-scott commented on June 5, 2024

Can you let me know if https://github.com/paragonie/sodium_compat/releases/tag/v1.6.4 fixed the issue for you?

from sodium_compat.

pmaziere avatar pmaziere commented on June 5, 2024

Still having the invalid MAC error in FileTest::testSeal, but the FileTest::testBox is now passed successfully

1) FileTest::testSeal
SodiumException: Invalid MAC

/srv/www/local/sodium_compat/src/Crypto32.php:1003
/srv/www/local/sodium_compat/src/Crypto32.php:664
/srv/www/local/sodium_compat/src/Crypto32.php:519
/srv/www/local/sodium_compat/src/Compat.php:983
/srv/www/local/sodium_compat/tests/unit/FileTest.php:147

ERRORS!
Tests: 173, Assertions: 6704, Errors: 1, Skipped: 58.

from sodium_compat.

pmaziere avatar pmaziere commented on June 5, 2024

After installing a VM on a 64 bits intel computer, I confirm that tests are passed successfully for this architecture. But I have the same 'Invalid MAC' error as described in my initial post with my Paseto attempt, therefore in addition to this bug report, I guess I must have something wrong in my paseto related code.
And I can't affirm that my Paseto 'invalid MAC' error is related to the sodium_compat FileTest::testSeal 'Invalid MAC' error.

from sodium_compat.

paragonie-scott avatar paragonie-scott commented on June 5, 2024

It wouldn't be. PASETO doesn't touch the File API at all.

from sodium_compat.

pmaziere avatar pmaziere commented on June 5, 2024

Ok, I confirm that the PASETO issue was unrelated to any sodium_compat bug. It is now fixed.

Anyway, I keep this bug opened since the FileTest::testSeal error is still pending. Maybe someone else could try to reproduce the bug, so that an isolated device specific issue can be ruled out.

from sodium_compat.

paragonie-scott avatar paragonie-scott commented on June 5, 2024

This fixes the unit tests on my Windows machine: c9ef28e

from sodium_compat.

paragonie-scott avatar paragonie-scott commented on June 5, 2024

This is fixed in v1.6.5.

from sodium_compat.

pmaziere avatar pmaziere commented on June 5, 2024

Not here (debian testing 64bit hosting an LXC guest running debian stretch 32bit)

1) FileTest::testSeal
SodiumException: Invalid MAC

/srv/www/local/sodium_compat/src/Crypto32.php:1003
/srv/www/local/sodium_compat/src/Crypto32.php:664
/srv/www/local/sodium_compat/src/Crypto32.php:519
/srv/www/local/sodium_compat/src/Compat.php:983
/srv/www/local/sodium_compat/tests/unit/FileTest.php:147

from sodium_compat.

paragonie-scott avatar paragonie-scott commented on June 5, 2024

Okay, I'm not able to reproduce this in v1.6.5 on my setup. I'll look into setting up a congruent system so I can study it further.

from sodium_compat.

pmaziere avatar pmaziere commented on June 5, 2024

Since you were not able to reproduce it, I cloned the repository from scratch and ran the tests again, with a fully successfull output this time.
Thanks for the time you spent on this bug, and for all your work.

from sodium_compat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.