crypto_box_seal is not available about halite HOT 25 CLOSED

See sektioneins/suhosin#92

from halite.

@Elbana Did you, perchance, install the PECL extension against an older version of libsodium then upgrade libsodium? If so, uninstall then reinstall the PECL extension, which was probably compiled against an older version.

from halite.

function_exists('\Sodium\crypto_box_seal') return false when it has leading slash but function_exists('Sodium\crypto_box_seal') it return true

That's... interesting. The leading slash just says "start from the global namespace". i.e.

namespace Foo\Sodium {
    function crypto_box_seal() {
        // backdoor!
    }
}
namepsace Foo {
    function bar() {
        $x = Sodium\crypto_box_seal(/* ... */);
    }

    function baz() {
        $x = \Sodium\crypto_box_seal(/* ... */);
    }
}

The only difference between the two is that baz() is explicit, but bar() will call Foo\Sodium\crypto_box_seal() first. Assuming no maliciously named function (in a namespace) exists, they should both resolve to the same destination.

from halite.

the function is working when i comment the check for the function exist but for some reason function_exists return false always , is there anything we can do around this check ?

from halite.

I don't know. That sounds like a PHP bug. What version of PHP are you running?

from halite.

I am using 5.6

from halite.

I cannot reproduce (5.6, 7.0)

BTW, try to use

'\\Sodium\\crypto_box_seal'

instead of

'\Sodium\crypto_box_seal'

from halite.

Hi remicollet, it is already used inside Asymmetric\Crypto::seal with double slashes I am just calling seal method but getting this error

from halite.

can we use is_callable() instead of function_existes() ?

from halite.

@Elbana Which PHP version are you using so that I can try to reproduce?

from halite.

Hi @clayfreeman I am using 5.6.23 thanks.

from halite.

@Elbana Could you run \ParagonIE\Halite::isLibsodiumSetupCorrectly(true); and paste the output as well?

from halite.

That method didn't exist in the version 1 branch, which is the only one that supported PHP 5.

    function isLibsodiumSetupCorrectly($echo = false)
    {
        // Require libsodium 1.0.9
        $major = \Sodium\library_version_major();
        $minor = \Sodium\library_version_minor();
        if ($major < 9 || ($major === 9 && $minor < 2)) {
            if ($echo) {
                echo 'Halite needs libsodium 1.0.9 or higher. You have: ',
                \Sodium\version_string(), "\n";
            }
            return false;
        }
        return true;
    }

from halite.

root@ubuntu:~/project# php main.php 
PHP CLI 5.6.11-1ubuntu3.4
Check if function exists with global namespace:    true
Check if function exists without global namespace: true

<?php
  require_once(__DIR__.'/vendor/autoload.php');
  echo "PHP CLI ".phpversion()."\n";
  echo "Check if function exists with global namespace:    ";
  echo var_export(function_exists('\\Sodium\\crypto_box_seal'), true)."\n";
  echo "Check if function exists without global namespace: ";
  echo var_export(function_exists('Sodium\\crypto_box_seal'), true)."\n";

Unable to reproduce on Ubuntu 15.10 with PHP 5.6.11 using CLI, latest tag on libsodium's repo, and latest version of PECL libsodium.

from halite.

Thanks guys for your help really appreciate it

isLibsodiumSetupCorrectly() true

var_dump([
\Sodium\library_version_major(),
\Sodium\library_version_minor(),
\Sodium\version_string()
]);

array (size=3)
0 => int 9
1 => int 2
2 => string '1.0.10' (length=6)

PHP CLI 5.6.23-1+deprecated+dontuse+deb.sury.org~trusty+1
Check if function exists with global namespace: false
Check if function exists without global namespace: true

from halite.

@Elbana It appears as though you're trying to use the PHP 7 branch with PHP 5, at least from what @paragonie-scott said earlier in this thread:

That method didn't exist in the version 1 branch, which is the only one that supported PHP 5.

Make sure that you're using at most v1.5.0 of Halite; anything newer supports PHP 7 only.

from halite.

Hi @clayfreeman I am using Halite v1.5.0 I just copied the method to my files.

from halite.

uninstall ok: channel://pecl.php.net/libsodium-1.0.6
install ok: channel://pecl.php.net/libsodium-1.0.6

still the same

from halite.

1. Uninstall PECL libsodium.
2. Uninstall libsodium.
3. Compile libsodium stable (1.0.10) from source.
4. Install PECL libsodium.

EDIT: Sorry if that seemed terse; I typed that this morning before a meeting. If these steps don't work, then there's likely a weird quirk with your copy of PHP.

from halite.

I have the same issue and apparently it's related to the suhosin module... I don't know why for the moment however.

# cat /rginstall/Test.php
<?php

require_once(__DIR__.'/vendor/autoload.php');
echo "PHP CLI ".phpversion()."\n";

if (extension_loaded('suhosin')) {
    echo "With suhosin enable\n";
} else {
    echo "With suhosin disable\n";
}

echo "Check if function exists with global namespace:    ";
echo var_export(function_exists('\\Sodium\\crypto_box_seal'), true)."\n";
echo "Check if function exists without global namespace: ";
echo var_export(function_exists('Sodium\\crypto_box_seal'), true)."\n";

//var_dump(get_extension_funcs('libsodium'));

The output is:

PHP CLI 5.6.21-1+donate.sury.org~trusty+4
With suhosin disable
Check if function exists with global namespace:    true
Check if function exists without global namespace: true


PHP CLI 5.6.21-1+donate.sury.org~trusty+4
With suhosin enable
Check if function exists with global namespace:    false
Check if function exists without global namespace: true

from halite.

Oh, interesting!

from halite.

Any idea how to fix it? Couldn't we use is_callable() instead of function_exists() maybe ? I'm not sure this will be patch on the suhosin side soon and I think a lot of people use both suhosin and halite...

from halite.

is_callable() works in Suhosin as expected? If so, I'll release a patch for 1.x and 2.x that makes this change.

from halite.

Proposed changes:

• Version 1 branch: 452f19e
• Version 2 branch: 0120005
• Version 3 branch (master): 030b6fb

If you could please confirm that this fixes the problem for you, I'll tag & sign new releases.

from halite.

@paragonie-scott This does fix the issue for me thanks guys for looking into this and thanks @Vincent-- for pointing the issue.

from halite.