Comments (4)
This would benefit from #30
from inky.
How would this benefit from #30?
I'd say we want numbers to remain literals and not references in our tests. If our tests and production code refer to the same values, we are not testing that the right values are being passed to the devices, making the tests weaker.
Being consistent in how we represent our integers is all fine and well, but going beyond that doesn't have clear benefits to me.
from inky.
Okay, that's fair. I agree that literals are probably the way to go. But I think module attributes in the test suite would be beneficial to clarity and reduce the risk of a hexadecimal number being replaced because it is identical but used for a different purpose in a different context. I think that risk is reduced with using module attributes in the test module as opposed to repeating the literals in every test.
What do you think about that approach?
from inky.
Sounds good!
from inky.
Related Issues (20)
- GenServerify the main entrypoint, Inky (inky.ex) HOT 5
- Experiment with higher SPI speeds HOT 9
- Consider making the busy waits into aspects of sync/async updates HOT 7
- Add credo check to CI
- Replace custom mock hackery with Mox HOT 2
- Add a convenient way to get display info by type HOT 2
- Allow setting an optional rotation
- Implement a post-push signal that can be requested by callers of `set_pixels` HOT 2
- Host dev library should handle border
- Not working with wHAT display HOT 17
- Update commands to be in line with current Python Inky HOT 3
- Use constants or something elegant for all the magic numbers HOT 3
- Version 1.0.1 cannot compile on Elixir 1.10 HOT 3
- Support the Inky Impression HOT 10
- display orientation upside down HOT 5
- Dev-mode display using wx? HOT 12
- set border color at creation and after creation HOT 3
- should we support the red high temperature screen type? HOT 2
- Validate display size on init HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inky.