Git Product home page Git Product logo

Comments (3)

morganist avatar morganist commented on June 30, 2024 1

from papirus-icon-theme.

morganist avatar morganist commented on June 30, 2024

@alexxons hi, can you please clarify in what way does the v0.18 spec change the way inherited themes work? wouldn't removing them cause missing icons for example in KDE apps, considering that not all Breeze icons are covered by Papirus?

from papirus-icon-theme.

alexxcons avatar alexxcons commented on June 30, 2024

Here the concrete line which was added to the spec.

Wouldn't removing them cause missing icons for example in KDE apps, considering that not all Breeze icons are covered by Papirus?

In theory, if Papirus provides all icons given in the icon-naming-spec, that should be sufficient. Since, if an App requires additional icons, according to the spec,that App should install these additional icons itself into the "hicolor" folder.

It might be that there are (KDE) Apps which miss installing these additional icons and rely on having breeze in the Inherit tree. If you notice so, you should report that to the app developer. If these icons are used by multiple applications, it might make sense to request a new icon-name for them on freedesktop.org, so that all themes will ship that icon.

In case you want to make sure that even such Apps which dont follow the standards are serviced with the KDE specific icons when using Papirus, it is fine to still keep breeze in the Inherits section. Though than you should make sure, that whenever Papirus is installed, as well breeze is installed (hard dependency). Since otherwise, users of the mentioned KDE Apps still won't have icons when installing only Papirus ... and they won't know why icons are missing / which theme to install to get them.

The best place to define a hard dependency to breeze probably would be, to write that into the README.md, so that packagers do know ... it might be required to open issues against distros as well, in order to inform them on the dependency.

from papirus-icon-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.