Comments (13)
Entity rewrite is not necessary in modern versions of Minecraft - this is not necessary.
from velocity.
But why bungeecord is using a entity rewrite?
from velocity.
Because BungeeCord is dumb.
from velocity.
You can not send a login packet twice, because some clients may have bugs or crashes (mods or cheats)
Without entity rewrite can cause a entity id duplication on client (entity and client player entity id)
from velocity.
Yes you can - you've been able to send the "join game" packet more than once for a while now.
from velocity.
Yes, you can send join game twice. but it cause bugs on modded clients(random disconnects, crashes). I am tested it and online was lower by ~20%
from velocity.
In bungeecord repo only one branch without entity rewrite.
On master Login packet from server is cancelled. https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/ServerConnector.java#L285
from velocity.
because some clients may have bugs or crashes (mods or cheats)
cheats
lolno. go away with that talk.
from velocity.
If you want to lose online, its a your chose. There are a lot of players with cheats. And with mods too.
I am already say, that online on my server was dropped by 20% when i try to use a alt-respawn.
from velocity.
It's your choice to press the fork button as well.
from velocity.
I just said to kashike why send login packet twice is bad.
Also there is commit with begin of entity rewrite, 515248f.
I just write some ideas how to make entity rewrite better, and reduce cpu usage by disabling entity rewrite.
from velocity.
On the branch which disables entity rewrites, it sends its own login packet, as opposed to passing through original one, so that it can send a login packet and then a respawn packet.
There are several servers which run their own forks of bungee without this entity rewrite logic without any issues, in fact, many modded servers take this approach and run perfectly fine and quite practically have no option other than this in order to run;
Are there going to be teething issues with some mods? Yes, but there is a whole idea here that by providing an environment which attempts to drop a lot of the quirky behavior that bungeecord shoves onto these mods sees a better chance of them actually attempting to provide some level of support for this software, as opposed to the current behavior of mod developers either providing support for it reluctantly, or shoving off support entirely.
from velocity.
Okey. Now i see, that velocity uses a rewriter/remapper only for 1.8.
But why you use it only for 1.8 if in 1.8 and 1.12.2 implementation/packet_handle is the same. https://www.diffchecker.com/Vrr01myy
from velocity.
Related Issues (20)
- PlayerEnterConfigurationEvent is not called on initial connect
- Resource pack callbacks are not triggered
- CorruptedFrameException: Bad VarInt decoded HOT 3
- If in plugins have one same plugin key-name , ALL plugins cannot be loaded
- io.netty.handler.codec.EncoderException: Sending unknown packet 'serverbound/minecraft:chat_session_update' HOT 17
- An event even before protocol version is checked HOT 2
- When `forced-hosts` section in config is gone, errors appear HOT 5
- [Feature] Domain name resolution support HOT 6
- Velocity [11:45:06] [Netty NIO Worker #7/WARN] [io.netty.channel.nio.NioEventLoop]: Failed to close the old Selector. HOT 1
- Velocity kicking players upon login HOT 1
- Client disconnects when Velocity does a server switch during bundle session HOT 1
- PlayerConnectionRequestEvent HOT 3
- Unable to connect to 1.20.4 Arclight server through modern forwarding HOT 1
- eaglercraft support HOT 1
- Players suddenly having high ping then getting kicked
- Feature: Read-only filesystem support HOT 1
- Velocity 3.3.0 Failing to connect to Fabric 1.20.1 HOT 1
- Switching logging frameworks HOT 4
- Limit on the Number of Players an IP Can Join in a Proxy HOT 2
- Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException: Cannot invoke "com.github.retrooper.packetevents.protocol.item.enchantment.type.EnchantmentType.getId(com.github.retrooper.packetevents.protocol.player.ClientVersion)" because "enchantment" is null HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from velocity.