Git Product home page Git Product logo

Comments (19)

 avatar commented on August 11, 2024

PaperMC/Waterfall#11 (comment)

from travertine.

BungeeTheCookie avatar BungeeTheCookie commented on August 11, 2024

@TiTo-418 Ah okay. So it's fixed in the new Waterfall, which this Travertine takes advantage of?

from travertine.

 avatar commented on August 11, 2024

@BungeeTheCookie I guess so

from travertine.

fuzzybot avatar fuzzybot commented on August 11, 2024

The second one should happen far less often.

from travertine.

BungeeTheCookie avatar BungeeTheCookie commented on August 11, 2024

@fuzzybot Is there any fix for it? And is the first one fixed?

from travertine.

Techcable avatar Techcable commented on August 11, 2024

We need to add the old commit to stop rate-limiting empty packets

from travertine.

BungeeTheCookie avatar BungeeTheCookie commented on August 11, 2024

@Techcable Okay! Would that be hard to do or..?

from travertine.

fuzzybot avatar fuzzybot commented on August 11, 2024

Ill add the config back soon if you are not already working on it

from travertine.

fuzzybot avatar fuzzybot commented on August 11, 2024

Techable, by default it is allowing 1 every 50ms hard coded

from travertine.

BungeeTheCookie avatar BungeeTheCookie commented on August 11, 2024

@fuzzybot what is the recommending setting (the setting that'd stop this issue), and why is there a rate-limit?

from travertine.

fuzzybot avatar fuzzybot commented on August 11, 2024

It is rate limited to prevent bad clients from spamming your server with emtpy packets. in waterfall-old it was a configurable setting, in travertine i just hard coded it to 1 every 50 ms allowed else kick the client. I will make it configurable again.

from travertine.

fuzzybot avatar fuzzybot commented on August 11, 2024

You should try travertine though, sounds like you have not actually tried it with this update applied to see if it fixes your issue.

from travertine.

fuzzybot avatar fuzzybot commented on August 11, 2024

see here,
https://github.com/WaterfallMC/Travertine/blob/master/Waterfall-Proxy-Patches/0006-1.7.x-Client-Support.patch#L157-L175

from travertine.

BungeeTheCookie avatar BungeeTheCookie commented on August 11, 2024

@fuzzybot I have not yet tried it. This is an issue I'm getting in Waterfall-Old when I sometimes chat (i.e. when chatcontrol blocks a curse word). I was waiting for this bug to be fixed so I could download Travertine.

from travertine.

BungeeTheCookie avatar BungeeTheCookie commented on August 11, 2024

It doesn't happen frequently either. It's just random (I'm beta testing so I don't have many examples due to not many players). Is there a Jenkins server or do I have to build it manually?

from travertine.

fuzzybot avatar fuzzybot commented on August 11, 2024

https://ci.aquifermc.org/job/Travertine/

from travertine.

BungeeTheCookie avatar BungeeTheCookie commented on August 11, 2024

@fuzzybot Thanks!

from travertine.

Techcable avatar Techcable commented on August 11, 2024

Oh, looks like this has been fixed in Travertine

from travertine.

fuzzybot avatar fuzzybot commented on August 11, 2024

closing as we have a fix in place for rate limiting empty packets instead of just not allowing them.

from travertine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.