Git Product home page Git Product logo

Comments (1)

papandreou avatar papandreou commented on August 12, 2024

Thanks for the report and for enjoying the library :)

There's probably some kind of fundamental mistake in how the code for some of these constructs is generated. As a first step, I've made a gist with the resulting code where it's easier to single step through it: https://gist.github.com/papandreou/71a79d4c32d4cefade6a678ce80fca46

From a quick glance it seems like it starts to go wrong in line 271:

function renderSpelloutNumberingT(n) {
  if (n >= 1000) return 'ERROR';
  if (n >= 100)
    return (
      this.renderSpelloutNumbering(Math.floor(n / 100)) +
      '\xADhundra' +
      (n === 100 ? '' : '\xAD' + this.renderSpelloutNumberingT(n % 100)) // <-----
    );

The n === 100 seems like the wrong criterion for recursing here, the logical thing would be to only call this.renderSpelloutNumberingT when n % 100 !== 0..

Again, I get really confused when reading the documentation while looking at

<rbnfrule value="1000">←%%spellout-numbering-t←­tusen[ →→];</rbnfrule>

from node-cldr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.