Groundouts-flyouts in pitcher results? about mlbgame HOT 7 CLOSED

@FlowFX I am not sure, I will check it out.

from mlbgame.

@panzarino rawboxscore.xml contains that info.
go and ao

<pitcher bam_s_er="21" bam_bs="0" hr="2" bam_hld="0" bis_bs="0" np="90" name_display_first_last="Joe Musgrove" game_score="48" pos="P" id="605397" bis_l="3" bam_l="3" bk="0" bis_w="2" name="Musgrove" bf="22" bis_era="5.02" bb="3" bam_s_so="28" bam_s_bb="13" bam_w="2" so="4" bis_hld="0" bam_s_r="22" win="true" pitch_order="100" h="4" bis_s_r="22" bam_s_ip="37.2" bam_era="5.02" bis_s_so="28" bis_s_h="39" bis_s_ip="37.2" bam_s_h="39" s="55" ao="0" bis_sv="0" r="2" bis_s_er="21" bam_sv="0" bis_s_bb="13" er="2" out="18" go="10">

from mlbgame.

@panzarino @trevor-viljoen I'd like to take a crack at this if you're cool with adding the feature.

I looked through the XMLs and indeed rawboxscore.xml is the only place I can find groundouts/flyouts (GO/AO). Do you have any concerns about adding the extra network call/XML tree parse?

from mlbgame.

@ajbowler Go for it! Would love to have a new feature for the library. For larger features, please try to keep the format similar to the way that the current functions work (although the design is not the best, I want to keep it consistent at this point).

from mlbgame.

I'll add the two stats to the existing player_stats call, I'm not seeing any additional stats the extra XML file gives us at the moment but I'll keep an eye out and open new issues if the data contains any further value

from mlbgame.

@ajbowler If you're changing the player_stats call could you also look at #57? If not, I can fix it but I figured it would be an easy fix and you would need that to work in order to properly test anyway.

from mlbgame.

It shouldn't impact either way since I'm grabbing stuff off the pitchers instead of the batters, but I can take a look while I'm in there.

from mlbgame.