Git Product home page Git Product logo

Comments (5)

bmcmahen avatar bmcmahen commented on August 11, 2024 1

The primary issue is that iOS react-native renders line-height such that the text is positioned at the bottom of the line-height, and not in the middle (as it does on the web). The android line-height seems to render differently, and clips the text if the line-height isn't sufficient. The kinda crappy fix for this now is to just up the line-height on android.

from panza.

bmcmahen avatar bmcmahen commented on August 11, 2024

What does your button code specifically look like?

from panza.

ruskid avatar ruskid commented on August 11, 2024
const { style } = this.props

    return (
      <PanzaButton
        primary {...this.props}
        style={[Style.fixButton].concat(style)}  />

export default {
  fixButton: {
    paddingBottom: (Platform.OS === 'ios') ? 0 : 5,
  }
}

I didn't test panza on ios, so it's 0.

from panza.

bmcmahen avatar bmcmahen commented on August 11, 2024

Yeah, this is really strange. iOS and android seem to have different line-height behaviour. I'm almost considering removing lineheight, since it doesn't seem very predictable. Trying to find the best solution for this...

from panza.

ruskid avatar ruskid commented on August 11, 2024

Will check it tomorrow and confirm!
up: Displays good, it's ok fix! Thanks

from panza.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.