Comments (5)
ferozco
commented on July 23, 2024
1
I don't think its desirable to support custom init.sh and I think there are a couple options you could try instead. For example, could you convert the CLI into to a server which exposes endpoints you can call (perhaps even use witchcraft) instead of wrapping it?
from sls-packaging.
ferozco
commented on July 23, 2024
Why do you want to overwrite the init.sh?
from sls-packaging.
brahms
commented on July 23, 2024
The reason we override init.sh is so that we can install and apollo manage a java based dropwizard CLI. The custom init.sh script starts up a python service that gets launched instead and gives green/red status back to Apollo so it think's its running. This allows the CLI to be Apollo managed.
from sls-packaging.
brahms
commented on July 23, 2024
If we don't fix this, I just resort to hacking my way around the plugin using tasks.createInitScript.enabled = false
from sls-packaging.
brahms
commented on July 23, 2024
Then the plugin should not allow an invalid tar with two headers to be created by validating that. Either way there probably should be a code change here.
from sls-packaging.
Related Issues (20)
- Differing classloaders can cause distribution plugins to miss dependency recommendations from within the repository HOT 2
- Locking asset configuration with GCV does not work if subprojects define their own repos
- Distribution tarballs contain bogus empty go-init and go-java-launcher directories
- Allow a library to mark a dep as optional HOT 1
- Increase default JFR stack depth beyond the default (conservative) 64 frames
- Use Async JVM Unified Logging on JDK 17+ HOT 1
- Enable UseStringDeduplication where feasible HOT 1
- Add validation to add a service dependency for new conjure projects
- Generate a product-dependencies.lock file for Recommended Product Dependencies Plugin
- productDependencies configuration might be broken with $project versions HOT 1
- Use 'hybrid' as default with java 11 and shenandoah with java 12
- var/log and var/run not created in distributions HOT 1
- sls-packaging Default JVM arguments are not applied in launcher scripts
- Implicit dependency on latest Gradle HOT 1
- Remove product dependency warning if higher version
- Support disabling inferred product dependencies HOT 3
- Remove gradle workaround HOT 1
- createManifest "succeeds" when ran with mismatched version of Java HOT 2
- Cannot easily override GC settings via configuration HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sls-packaging.