Git Product home page Git Product logo

Comments (4)

karismatic-megafauna avatar karismatic-megafauna commented on March 28, 2024

Two things here:

  1. in your code, this line => props.actionFunction();
    should actually be => props.action();
    this is because the prop key you are assigning actionFunction to is action.

  2. even if that isn't the issue, i don't think you can access props in this way with this wrapper... (where does props come from?)

from react.

karismatic-megafauna avatar karismatic-megafauna commented on March 28, 2024

Oh, i think the answer is here => https://github.com/NeroCor/react-p5-wrapper#usage

Where it is defined:

  p.myCustomRedrawAccordingToNewPropsHandler = function (props) {
    if (props.rotation){
      rotation = props.rotation * Math.PI / 180;
    }
  };

and where it is used:

  <P5Wrapper sketch={sketch} rotation={rotation} />

notice that the name "myCustomRedrawAccordingToNewPropsHandler" is important:

in the source code, you need to call that name exactly to get rotation on your props.

from react.

jamesrweb avatar jamesrweb commented on March 28, 2024

@karismatic-megafauna, @sjorsvanheuveln yeah, this is how it works from what I have seen too, I refactored some code in #48 but hoping to also edit this because it is actually implemented in such a way that it polluted the p5 namespace as you can see at index.ts line 30.

Currently I think I will propose a simple options object to be kept in state and passing down the setOptions handler for people to Lift state up and read-on-render as required. Any thoughts on this?

from react.

jamesrweb avatar jamesrweb commented on March 28, 2024

Closing due to inactivity. For those viewing this issue in the future, a related PR of interest could be #65 depending how that one develops.

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.