Comments (4)
Two things here:
-
in your code, this line =>
props.actionFunction();
should actually be =>props.action();
this is because the prop key you are assigningactionFunction
to isaction
. -
even if that isn't the issue, i don't think you can access props in this way with this wrapper... (where does props come from?)
from react.
Oh, i think the answer is here => https://github.com/NeroCor/react-p5-wrapper#usage
Where it is defined:
p.myCustomRedrawAccordingToNewPropsHandler = function (props) {
if (props.rotation){
rotation = props.rotation * Math.PI / 180;
}
};
and where it is used:
<P5Wrapper sketch={sketch} rotation={rotation} />
notice that the name "myCustomRedrawAccordingToNewPropsHandler" is important:
in the source code, you need to call that name exactly to get rotation
on your props
.
from react.
@karismatic-megafauna, @sjorsvanheuveln yeah, this is how it works from what I have seen too, I refactored some code in #48 but hoping to also edit this because it is actually implemented in such a way that it polluted the p5
namespace as you can see at index.ts line 30.
Currently I think I will propose a simple options
object to be kept in state and passing down the setOptions
handler for people to Lift state up and read-on-render as required. Any thoughts on this?
from react.
Closing due to inactivity. For those viewing this issue in the future, a related PR of interest could be #65 depending how that one develops.
from react.
Related Issues (20)
- Migrate to Vite and Vitest
- Migrate to the @P5-wrapper npm org
- Loading image P5-react
- React's strict mode causes the canvas to be created twice HOT 4
- An example of exposing imperative methods from the sketch? HOT 9
- unexpected array behavior inside p5 sketch function HOT 1
- ReactP5Wrapper has additional pixels in height HOT 3
- Could not find a declaration file but the code works HOT 10
- Duplicate canvas when running in vite dev HOT 5
- TypeError: p5.loadSound is not a function HOT 3
- P5-wrapper size HOT 5
- Stop rerender of p5 component when redux variables update HOT 3
- Latest commits not in the npm registry HOT 5
- Issue building with Vite 5 HOT 16
- npm ERR! Usage Error: This project is configured to use npm HOT 2
- windowResized() not firing HOT 4
- Error in nextjs HOT 7
- Change p5 dependency version to minimum 1.4.1 HOT 9
- Examples directory doesn't exist, link broken on README HOT 3
- Module parse failed: Identifier 'XX' has already been declared (7762:41) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react.