Git Product home page Git Product logo

Comments (5)

fruffy avatar fruffy commented on July 20, 2024 3

In general, I would clean up the original PRs before we can even start to make suggestions on how to break them down. This means removing nanomsg and thrift.

from behavioral-model.

qobilidop avatar qobilidop commented on July 20, 2024

Ping @antoninbas @jafingerhut @thantry @drobinkent

from behavioral-model.

qobilidop avatar qobilidop commented on July 20, 2024

First, thank you @rupesh-chiluka-marvell for your effort on open sourcing this work!

I'm not the most qualified person to give suggestions here, but just want to share some high-level thoughts and hopefully stimulate more discussions that could lead to better and more detailed solutions.

Regarding PR splitting, I think a test-driven approach might work for this process. The idea is to split into a series of PRs with each making a single P4 test program work. For example, the first PR could introduce minimal changes to BMv2 and p4c to enable a minimal P4 PNA program (e.g. single state parser + empty control block) to compile with p4c and run with BMv2. Each subsequent PRs will make the test P4 program a little bit more complicated.

from behavioral-model.

qobilidop avatar qobilidop commented on July 20, 2024

Also to give a better context to everyone, I'd like to attach @antoninbas's suggestion from the email thread:

We will have a better idea of the actual size of the bmv2 PR once the nanomsg files are removed. But yes, there should be potential for splitting up the PR after that, e.g., externs could be added in a subsequent PR.

from behavioral-model.

rupesh-chiluka-marvell avatar rupesh-chiluka-marvell commented on July 20, 2024

Created a new PR with just skeleton of pna_nic: #1255

from behavioral-model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.